Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding bazelmod#1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gittiver merged 8 commits intoCrowCpp:masterfromsebastianbergt:adding-bazelmod
May 29, 2025
Merged

Conversation

@sebastianbergt
Copy link

@sebastianbergtsebastianbergt commentedMar 12, 2025•
edited
Loading

Hi,

would you accept a bazel module in your code?
I am trying to add CrowCpp tobazel registry and hence did the work anyway.
Also, if you are interested, I can add the test to the bazel build.

@gittivergittiver marked this pull request as draftMarch 13, 2025 07:46
@gittiver
Copy link
Member

gittiver commentedMar 13, 2025•
edited
Loading

bazel build does not work on macOs, I put it back into draft.

@sebastianbergt
Copy link
Author

sebastianbergt commentedMar 29, 2025•
edited
Loading

bazel build does not work on macOs, I put it back into draft.

Thank you for the quick review and detailled feedback :)

@gittiver
Copy link
Member

There is a problem on macOS.

Copy link
Member

@gittivergittiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

set back to Draft as it does not build on MacOS 13

@sebastianbergt
Copy link
Author

set back to Draft as it does not build on MacOS 13

Hei@gittiver
sorry for the delay. I sadly had to remove mac-os from the list of tested systems,
since dependencies are not compiling on it.

@sebastianbergtsebastianbergt marked this pull request as ready for reviewMay 22, 2025 09:48
its not supported by github anymore
@gittivergittiver merged commitbf4ac33 intoCrowCpp:masterMay 29, 2025
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gittivergittivergittiver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastianbergt@gittiver
[8]ページ先頭
©2009-2025 Movatter.jp