- Notifications
You must be signed in to change notification settings - Fork146
[WIP] Miner support MQTT protocol#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…eader of a database.
| @@ -106,6 +106,14 @@ type DNSSeed struct { | |||
| BPCount int `yaml:"BPCount"` | |||
| } | |||
| type MQTTBrokerInfo struct { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported type MQTTBrokerInfo should have comment or be unexported
| @@ -1020,6 +1020,10 @@ func (c *Chain) AddResponse(resp *types.SignedResponseHeader) (err error) { | |||
| return c.ai.addResponse(c.rt.getHeightFromTime(resp.GetRequestTimestamp()), resp) | |||
| } | |||
| func (c *Chain) GetPeerLeaderID() proto.NodeID { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported method Chain.GetPeerLeaderID should have comment or be unexported
| "github.com/gogf/gf/g/container/gqueue" | ||
| ) | ||
| type MQTTAPI string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported type MQTTAPI should have comment or be unexported
| type MQTTAPI string | ||
| const ( | ||
| //Publish API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
comment on exported const MQTTNewest should be of the form "MQTTNewest ..."
| const ( | ||
| //Publish API | ||
| MQTTNewest MQTTAPI = "newest" | ||
| DSNList MQTTAPI = "dsnlist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported const DSNList should have comment (or a comment on this block) or be unexported
| type SubscribeEvent struct { | ||
| ClientID proto.NodeID | ||
| DatabaseID proto.DatabaseID | ||
| ApiName MQTTAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
struct field ApiName should be APIName
| Payload BrokerPayload | ||
| } | ||
| type MQTTClient struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported type MQTTClient should have comment or be unexported
| return dests | ||
| } | ||
| func NewMQTTClient(config *conf.MQTTBrokerInfo, dbms *DBMS) (c *MQTTClient) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported function NewMQTTClient should have comment or be unexported
| } | ||
| } | ||
| func (c *MQTTClient) PublishDSN(apiName MQTTAPI, databaseID proto.DatabaseID, payload BrokerPayload, requestClient proto.NodeID) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported method MQTTClient.PublishDSN should have comment or be unexported
| return nil | ||
| } | ||
| func (c *MQTTClient) Close() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[golint]reported byreviewdog 🐶
exported method MQTTClient.Close should have comment or be unexported
No description provided.