- Notifications
You must be signed in to change notification settings - Fork17
refactor tutorial#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- move js code from tutorial.html to js file - use - in front of jekyll commands to remove white space - remove test output of language tag - remove jquery because the selected language is selected in jekyll
DaricusDuncan commentedMar 6, 2018
@niccokunzmann Everything looks great. Is there anything specific you needed me to do for this? |
niccokunzmann commentedMar 6, 2018
@DaricusDuncan No, nothing specific. Thanks for having a look. Through pull requests we can spread knowledge and appreciation :) If you like, you can merge. |
niccokunzmann commentedMar 7, 2018
I merged it to not forget it. Thanks for reviewing :) |
DaricusDuncan commentedMar 8, 2018
@niccokunzmann You are welcome. I forgot to respond back to you yesterday, but I did not have access to merge. The button to merge was not clickable. I should have told you sooner. |
Uh oh!
There was an error while loading.Please reload this page.