Commit1798edd

authored

fix: Failed to resolve the Node executable path when it contains spaces (LeetCode-OpenSource#363)

1 parent453c51a commit1798eddCopy full SHA for 1798edd

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@`
`127`	`127`	\|(Deprecated)`leetcode.enableShortcuts`\| Specify whether the submit and test shortcuts in editor or not.\|`true`\|
`128`	`128`	\|`leetcode.editor.shortcuts`\| Specify the customized shorcuts in editors. Supported values are:`submit`,`test`,`solution` and`description`.\|`["submit, test"]`\|
`129`	`129`	\|`leetcode.enableSideMode`\| Specify whether`preview`,`solution` and`submission` tab should be grouped into the second editor column when solving a problem.\|`true`\|
`130`		-\|`leetcode.nodePath`\| Specify the`Node.js` executable path.\|`node`\|
	`130`	+\|`leetcode.nodePath`\| Specify the`Node.js` executable path.for example, C:\Program Files\nodejs\node.exe\|`node`\|
`131`	`131`
`132`	`132`	`##Want Help?`
`133`	`133`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@`
`127`	`127`	\|(Deprecated)`leetcode.enableShortcuts`\| 指定是否在 VS Code 编辑文件下方显示提交和测试的快捷按钮。\|`true`\|
`128`	`128`	\|`leetcode.editor.shortcuts`\| 指定在编辑器内所自定义的快捷方式。可用的快捷方式有:`submit`,`test`,`solution`,`description`。\|`["submit, test"]`\|
`129`	`129`	\|`leetcode.enableSideMode`\| 指定在解决一道题时，是否将`问题预览`、`高票答案`与`提交结果`窗口集中在编辑器的第二栏。\|`true`\|
`130`		-\|`leetcode.nodePath`\| 指定`Node.js` 可执行文件的路径。\|`node`\|
	`130`	+\|`leetcode.nodePath`\| 指定`Node.js` 可执行文件的路径。如：C:\Program Files\nodejs\node.exe\|`node`\|
`131`	`131`
`132`	`132`	`##需要帮助？`
`133`	`133`	`在遇到任何问题时，可以先查看一下[疑难解答](https://github.com/jdneo/vscode-leetcode/wiki/%E7%96%91%E9%9A%BE%E8%A7%A3%E7%AD%94)以及[常见问题](https://github.com/jdneo/vscode-leetcode/wiki/%E5%B8%B8%E8%A7%81%E9%97%AE%E9%A2%98)寻求帮助。`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@`
`361`	`361`	`"type":"string",`
`362`	`362`	`"default":"node",`
`363`	`363`	`"scope":"application",`
`364`		`-"description":"The Node.js executable path."`
	`364`	`+"description":"The Node.js executable path. for example, C:\\Program Files\\nodejs\\node.exe"`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,8 @@ class LeetCodeExecutor implements Disposable {`
`49`	`49`	`if(!awaitfse.pathExists(this.nodeExecutable)){`
`50`	`50`	thrownewError(`The Node.js executable does not exist on path${this.nodeExecutable}`);
`51`	`51`	`}`
	`52`	`+// Wrap the executable with "" to avoid space issue in the path.`
	`53`	+this.nodeExecutable=`"${this.nodeExecutable}"`;
`52`	`54`	`if(useWsl()){`
`53`	`55`	`this.nodeExecutable=awaittoWslPath(this.nodeExecutable);`
`54`	`56`	`}`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,10 @@ export async function getActiveFilePath(uri?: vscode.Uri): Promise<string \| unde`
`64`	`64`
`65`	`65`	`functionisSubFolder(from:string,to:string):boolean{`
`66`	`66`	`constrelative:string=path.relative(from,to);`
`67`		`-return!!relative&&!relative.startsWith("..")&&!path.isAbsolute(relative);`
	`67`	`+if(relative===""){`
	`68`	`+returntrue;`
	`69`	`+}`
	`70`	`+return!relative.startsWith("..")&&!path.isAbsolute(relative);`
`68`	`71`	`}`
`69`	`72`
`70`	`73`	`enumOpenOption{`

Comments

(0)