Commit1572c7a

authored

fix: Cannot show description page (LeetCode-OpenSource#345)

1 parent123d95b commit1572c7aCopy full SHA for 1572c7a

File tree

+13

-14

lines changed

+13

-14

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,17 +20,15 @@ import { leetCodeSolutionProvider } from "../webview/leetCodeSolutionProvider";`
`20`	`20`	`import*aslistfrom"./list";`
`21`	`21`
`22`	`22`	`exportasyncfunctionpreviewProblem(input:IProblem\|vscode.Uri,isSideMode:boolean=false):Promise<void>{`
`23`		`-letnode:LeetCodeNode;`
`24`		`-if(inputinstanceofLeetCodeNode){`
`25`		`-node=input;`
`26`		`-}elseif(inputinstanceofvscode.Uri){`
	`23`	`+letnode:IProblem;`
	`24`	`+if(inputinstanceofvscode.Uri){`
`27`	`25`	`constactiveFilePath:string=input.fsPath;`
`28`	`26`	`constid:string=awaitgetNodeIdFromFile(activeFilePath);`
`29`	`27`	`if(!id){`
`30`	`28`	vscode.window.showErrorMessage(`Failed to resolve the problem id from file:${activeFilePath}.`);
`31`	`29`	`return;`
`32`	`30`	`}`
`33`		`-constcachedNode:LeetCodeNode\|undefined=explorerNodeManager.getNodeById(id);`
	`31`	`+constcachedNode:IProblem\|undefined=explorerNodeManager.getNodeById(id);`
`34`	`32`	`if(!cachedNode){`
`35`	`33`	vscode.window.showErrorMessage(`Failed to resolve the problem with id:${id}.`);
`36`	`34`	`return;`
`@@ -39,8 +37,7 @@ export async function previewProblem(input: IProblem \| vscode.Uri, isSideMode: b`
`39`	`37`	`// Move the preview page aside if it's triggered from Code Lens`
`40`	`38`	`isSideMode=true;`
`41`	`39`	`}else{`
`42`		`-vscode.window.showErrorMessage("Invalid input to fetch the preview data.");`
`43`		`-return;`
	`40`	`+node=input;`
`44`	`41`	`}`
`45`	`42`
`46`	`43`	`constdescString:string=awaitleetCodeExecutor.getDescription(node.id);`

Lines changed: 9 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,11 @@ class LeetCodePreviewProvider extends LeetCodeWebview {`
`22`	`22`	`this.node=node;`
`23`	`23`	`this.sideMode=isSideMode;`
`24`	`24`	`this.showWebviewInternal();`
`25`		`-if(this.sideMode){`
`26`		`-this.hideSideBar();// For better view area`
`27`		`-}`
	`25`	`+// Comment out this operation since it sometimes may cause the webview become empty.`
	`26`	`+// Waiting for the progress of the VS Code side issue: https://github.com/microsoft/vscode/issues/3742`
	`27`	`+// if (this.sideMode) {`
	`28`	`+// this.hideSideBar(); // For better view area`
	`29`	`+// }`
`28`	`30`	`}`
`29`	`31`
`30`	`32`	`protectedgetWebviewOption():ILeetCodeWebviewOption{`
`@@ -134,10 +136,10 @@ class LeetCodePreviewProvider extends LeetCodeWebview {`
`134`	`136`	`}`
`135`	`137`	`}`
`136`	`138`
`137`		`-privateasynchideSideBar():Promise<void>{`
`138`		`-awaitcommands.executeCommand("workbench.action.focusSideBar");`
`139`		`-awaitcommands.executeCommand("workbench.action.toggleSidebarVisibility");`
`140`		`-}`
	`139`	`+//private async hideSideBar(): Promise<void> {`
	`140`	`+// await commands.executeCommand("workbench.action.focusSideBar");`
	`141`	`+// await commands.executeCommand("workbench.action.toggleSidebarVisibility");`
	`142`	`+//}`
`141`	`143`
`142`	`144`	`privateparseDescription(descString:string,problem:IProblem):IDescription{`
`143`	`145`	`const[`

Comments

(0)