Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't Try to Set a Negative Frame Height#96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@thecoolwinter
Copy link
Contributor

Description

Fixes a potential recursion where CETV tries to set it's frame to a negative number (due to overscroll & scroll inset weirdness). This adds a super simple sanity check to make sure we limit the textview to a0 frame at minimum.

This hang would occur when no content is present, making the content size an odd number, which also makes scroll views freak out on macOS.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A, fixes a hang.

@thecoolwinterthecoolwinter merged commitd51f3ad intoCodeEditApp:mainMay 27, 2025
2 checks passed
@thecoolwinterthecoolwinter added the bugSomething isn't working labelMay 27, 2025
@thecoolwinterthecoolwinter deleted the fix/frame-height-sanity-check branchMay 27, 2025 19:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thecoolwinter

[8]ページ先頭

©2009-2025 Movatter.jp