- Notifications
You must be signed in to change notification settings - Fork21
Emphasis Manager Enhancements#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…stead of a custom color.
…match cycle logic from EmphasisManager to FindViewController. Using EmphasisManager in bracket pair matching instead of custom implementation reducing duplicated code. Implemented flash find matches when clicking the next and previous buttons when the editor is in focus. `bracketPairHighlight` becomes `bracketPairEmphasis`. Fixed various find issues and cleaned up implementation.
thecoolwinter left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some missing questions about the selection manager and line fragment rendering changes.weak references and
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…odeEditTextView into feat/in-doc-search
tom-ludwig left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
austincondiff commentedApr 6, 2025
Merging,@tom-ludwig previously approved. |
fe36e69 intomainUh oh!
There was an error while loading.Please reload this page.
> [!IMPORTANT]> ~~We need to mergeCodeEditApp/CodeEditTextView#78 before mergingthis PR.~~### DescriptionThis PR introduces the initial implementation of the “Find in Editor”feature for the source editor. Users can now search for text within thecurrently open file using ⌘ F. All matching results are visuallyemphasized, and users can navigate between matches using next/previouscontrols.What’s Included- Text search across the current document- Match highlighting with emphasis on the currently selected match- Keyboard shortcut support: ⌘ F to activate the find bar- Looping navigation with HUD notifications:- Reaching the end → loops to first result (arrow.triangle.capsulepath)- Reaching the beginning → loops to last result (flippedarrow.triangle.capsulepath)- No more matches → arrow.down.to.line HUD icon displayed### Related Issues-CodeEditApp/CodeEditTextView#1-closesCodeEditApp/CodeEditTextView#3-CodeEditApp/CodeEditTextView#78* #ISSUE_NUMBER### Checklist<!--- Add things that are not yet implemented above -->- [x] I read and understood the [contributingguide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)as well as the [code ofconduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)- [x] The issues this PR addresses are related to each other- [x] My changes generate no new warnings- [x] My code builds and runs on my machine- [x] My changes are all related to the related issue above- [x] I documented my code### Screenshots<!--- REQUIRED: if issue is UI related --><!--- IMPORTANT: Fill out all required fields. Otherwise we might closethis PR temporarily -->---------Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Description
Renamed EmphasizeAPI to EmphasisManager. It now supports various emphasis styles including standard highlights, underlines, and outlines, with optional behaviors such as flashing, selection, and inactive styling.
Key Features:
This enables visual feedback for features like search highlights, bracket pair emphasis, and other temporary visual cues in the editor.
Related Issues
Checklist
Screenshots