Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Emphasis Manager Enhancements#78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
austincondiff merged 21 commits intomainfromfeat/in-doc-search
Apr 6, 2025
Merged

Conversation

@austincondiff
Copy link
Contributor

@austincondiffaustincondiff commentedMar 31, 2025
edited
Loading

Description

Renamed EmphasizeAPI to EmphasisManager. It now supports various emphasis styles including standard highlights, underlines, and outlines, with optional behaviors such as flashing, selection, and inactive styling.

Key Features:

  • EmphasisStyle enum for flexible styling (standard, underline, outline)
  • Emphasis struct to represent emphasis metadata (range, style, flash, etc.)
  • EmphasisManager class to:
    • Add, replace, and update emphases by group ID
    • Apply animations (e.g. pop, fade-out)
    • Handle selection and scrolling
    • Sync emphasis layer bounds with text layout
  • Internal caching of selection color and support for inactive visual state

This enables visual feedback for features like search highlights, bracket pair emphasis, and other temporary visual cues in the editor.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image

austincondiffand others added5 commitsMarch 13, 2025 10:48
…match cycle logic from EmphasisManager to FindViewController. Using EmphasisManager in bracket pair matching instead of custom implementation reducing duplicated code. Implemented flash find matches when clicking the next and previous buttons when the editor is in focus. `bracketPairHighlight` becomes `bracketPairEmphasis`. Fixed various find issues and cleaned up implementation.
Copy link
Contributor

@thecoolwinterthecoolwinter left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some missingweak references and questions about the selection manager and line fragment rendering changes.

tom-ludwig
tom-ludwig previously approved these changesMar 31, 2025
Copy link
Member

@tom-ludwigtom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@austincondiff
Copy link
ContributorAuthor

Merging,@tom-ludwig previously approved.

@austincondiffaustincondiff merged commitfe36e69 intomainApr 6, 2025
2 checks passed
@austincondiffaustincondiff deleted the feat/in-doc-search branchApril 6, 2025 15:22
thecoolwinter added a commit to CodeEditApp/CodeEditSourceEditor that referenced this pull requestApr 8, 2025
> [!IMPORTANT]> ~~We need to mergeCodeEditApp/CodeEditTextView#78 before mergingthis PR.~~### DescriptionThis PR introduces the initial implementation of the “Find in Editor”feature for the source editor. Users can now search for text within thecurrently open file using ⌘ F. All matching results are visuallyemphasized, and users can navigate between matches using next/previouscontrols.What’s Included- Text search across the current document- Match highlighting with emphasis on the currently selected match- Keyboard shortcut support: ⌘ F to activate the find bar- Looping navigation with HUD notifications:- Reaching the end → loops to first result (arrow.triangle.capsulepath)- Reaching the beginning → loops to last result (flippedarrow.triangle.capsulepath)- No more matches → arrow.down.to.line HUD icon displayed### Related Issues-CodeEditApp/CodeEditTextView#1-closesCodeEditApp/CodeEditTextView#3-CodeEditApp/CodeEditTextView#78* #ISSUE_NUMBER### Checklist<!--- Add things that are not yet implemented above -->- [x] I read and understood the [contributingguide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)as well as the [code ofconduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)- [x] The issues this PR addresses are related to each other- [x] My changes generate no new warnings- [x] My code builds and runs on my machine- [x] My changes are all related to the related issue above- [x] I documented my code### Screenshots<!--- REQUIRED: if issue is UI related --><!--- IMPORTANT: Fill out all required fields. Otherwise we might closethis PR temporarily -->---------Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@thecoolwinterthecoolwinterthecoolwinter approved these changes

@tom-ludwigtom-ludwigtom-ludwig left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austincondiff@thecoolwinter@tom-ludwig

[8]ページ先頭

©2009-2025 Movatter.jp