Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added mouse drag selection modes#75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
thecoolwinter merged 2 commits intomainfromupdate_drag_selection
Mar 31, 2025
Merged

Conversation

@FastestMolasses
Copy link
Member

Description

There are 3 different selection modes that editors typically have when clicking and dragging the mouse.

  1. Character - simple click and drag to select by character
  2. Word - double click a word and then drag to start selecting by word ranges
  3. Line - triple click and drag to start selecting by entire lines

This PR tracks and implements the different selection mode behaviors.

Related Issues

Closes#74

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Character selection (default behavior, unchanged)

Screen.Recording.2025-03-30.at.6.12.36.AM.mov

Double click for word selection

Screen.Recording.2025-03-30.at.6.14.26.AM.mov

Triple click for line selection

output.mov

austincondiff reacted with thumbs up emoji
Copy link
Contributor

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works like a charm, can I just request a small re-arrange? I dislike this new enum being in theTextSelection file (since that's a specific struct type and is unrelated).

Could we rename it toCursorSelectionMode and move it to it's own file?

FastestMolasses reacted with thumbs up emoji
@FastestMolasses
Copy link
MemberAuthor

Updated!

Copy link
Contributor

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!

@thecoolwinterthecoolwinter merged commite86ca59 intomainMar 31, 2025
2 checks passed
@thecoolwinterthecoolwinter deleted the update_drag_selection branchMarch 31, 2025 13:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@thecoolwinterthecoolwinterthecoolwinter approved these changes

@austincondiffaustincondiffAwaiting requested review from austincondiff

@tom-ludwigtom-ludwigAwaiting requested review from tom-ludwig

Assignees

@FastestMolassesFastestMolasses

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ Different Selection Modes When Dragging Mouse

3 participants

@FastestMolasses@thecoolwinter
[8]ページ先頭
©2009-2025 Movatter.jp