Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move All Delegate Calls Outside Layout Pass#57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@thecoolwinter
Copy link
Contributor

@thecoolwinterthecoolwinter commentedNov 17, 2024•
edited
Loading

Description

  • Moves a few more delegate calls or delegate triggering calls outside the protected area inlayoutLines to prevent crashes. These are safe to call outside the intended protected area.
  • Documents an important layout method.
  • Fixes a flaking test by sorting selection ranges after deleting.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

Copy link
Member

@tom-ludwigtom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good, but could you create an issue and reference it here before we merge? Matties always stressed the importance of having an issue first to make it easier to understand the history of merged PRs

@thecoolwinter
Copy link
ContributorAuthor

looks good, but could you create an issue and reference it here before we merge? Matties always stressed the importance of having an issue first to make it easier to understand the history of merged PRs

Absolutely, referenced as#58.

@thecoolwinterthecoolwinter merged commit509d7b2 intoCodeEditApp:mainNov 18, 2024
2 checks passed
@thecoolwinterthecoolwinter deleted the fix/layout-assertion branchNovember 18, 2024 15:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tom-ludwigtom-ludwigtom-ludwig approved these changes

@austincondiffaustincondiffAwaiting requested review from austincondiff

@0xWDG0xWDGAwaiting requested review from 0xWDG

@matthijseikelenboommatthijseikelenboomAwaiting requested review from matthijseikelenboom

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Layout Pass Protection

2 participants

@thecoolwinter@tom-ludwig
[8]ページ先頭
©2009-2025 Movatter.jp