Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Marked Text Input#40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@thecoolwinter
Copy link
Contributor

Description

Fixes marked text input for sequences longer than one marked character. Also ensures marked text works consistently with multiple cursors and adds testing for the marked text functionality.

Also:

  • Fixes a few lint markers in test files that have caused issues for others.
  • Adds a publicTextView.markedTextAttributes property for modifying the marked text attributes if desired.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-06-22.at.12.45.56.AM.mov

@RonghuaHe
Copy link

Hello, the previous issue is resolved, but now we have a new issue:when using Chinese or Japanese input method, input part of Chinese or Japanese, and then press the enter key, the text will be accidentally hidden.

@thecoolwinter
Copy link
ContributorAuthor

Hello, the previous issue is resolved, but now we have a new issue:when using Chinese or Japanese input method, input part of Chinese or Japanese, and then press the enter key, the text will be accidentally hidden.

I'll look into this again, thank you for bringing it up

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@austincondiffaustincondiffaustincondiff approved these changes

@FastestMolassesFastestMolassesAwaiting requested review from FastestMolasses

@bombardier200bombardier200Awaiting requested review from bombardier200

@matthijseikelenboommatthijseikelenboomAwaiting requested review from matthijseikelenboom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@thecoolwinter@RonghuaHe@austincondiff

[8]ページ先頭

©2009-2025 Movatter.jp