- Notifications
You must be signed in to change notification settings - Fork21
General Performance Improvements#24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
thecoolwinter merged 3 commits intoCodeEditApp:mainfromthecoolwinter:fix/scroll-layout-performanceFeb 21, 2024
Merged
General Performance Improvements#24
thecoolwinter merged 3 commits intoCodeEditApp:mainfromthecoolwinter:fix/scroll-layout-performanceFeb 21, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sources/CodeEditTextView/TextLayoutManager/TextLayoutManager.swift OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
austincondiff approved these changesFeb 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
layoutManager.endTransactionmethod to only force layout if determined to be necessary by the caller, dramatically reducing the number of times complete layout occurs.hitTestmethod onTextViewto just returnselfif the hit is in the visible rect (was taking 100's of ms to perform before).TextLayoutManager. This fixes a small visible bug where scrolling very fast would briefly lag behind on layout and lines would not be rendered immediately. With this change, the lag still occurs but it happens invisibly to the user.For the last point, it was determined that the slowest part of the layout process is actually removing line fragment views from the hierarchy. Other methods were explored such as hiding views or setting their frame to 0 in place of removing them, but similar performance hits occurred.
Related Issues
Checklist