NotificationsYou must be signed in to change notification settings
Fork21
Star154

Commitd51f3ad

authored

Don't Try to Set a Negative Frame Height (#96)

### DescriptionFixes a potential recursion where CETV tries to set it's frame to a negative number (due to overscroll & scroll inset weirdness). This adds a super simple sanity check to make sure we limit the textview to a `0` frame at minimum.This hang would occur when no content is present, making the content size an odd number, which also makes scroll views freak out on macOS.### Related Issues*CodeEditApp/CodeEdit#2049### Checklist- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)- [x] The issues this PR addresses are related to each other- [x] My changes generate no new warnings- [x] My code builds and runs on my machine- [x] My changes are all related to the related issue above- [x] I documented my code### ScreenshotsN/A, fixes a hang.

1 parentd82b1c0 commitd51f3adCopy full SHA for d51f3ad

File tree

1 file changed

-1

lines changed

Sources/CodeEditTextView/TextView
- TextView+Layout.swift

1 file changed

-1

lines changed

`‎Sources/CodeEditTextView/TextView/TextView+Layout.swift‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ extension TextView {`
`72`	`72`	`availableSize.height-=(scrollView?.contentInsets.top??0)+(scrollView?.contentInsets.bottom??0)`
`73`	`73`
`74`	`74`	`letextraHeight= availableSize.height* overscrollAmount`
`75`		`-letnewHeight=max(layoutManager.estimatedHeight()+ extraHeight, availableSize.height)`
	`75`	`+letnewHeight=max(layoutManager.estimatedHeight()+ extraHeight, availableSize.height,0)`
`76`	`76`	`letnewWidth= layoutManager.estimatedWidth()`
`77`	`77`
`78`	`78`	`vardidUpdate=false`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd51f3ad

File tree

1 file changed

1 file changed

`‎Sources/CodeEditTextView/TextView/TextView+Layout.swift‎`

0 commit comments