- Notifications
You must be signed in to change notification settings - Fork112
Fix End Of Doc Crash#285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfromthecoolwinter:fix/end-of-doc-crashJan 7, 2025
Merged
Fix End Of Doc Crash#285
thecoolwinter merged 2 commits intoCodeEditApp:mainfromthecoolwinter:fix/end-of-doc-crashJan 7, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
FastestMolasses approved these changesJan 7, 2025
63bae5a intoCodeEditApp:main 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash that occurred when editing the last characters in a file. This was missed by tests because it only appeared when syntax highlighting was applied.
Added a test case that catches this case in the styled range store. Added a second test in the highlighter tests that catches this and hopefully helps prevent some future bugs related to the highlighter.
Also added the package tests to the example app so tests can be run from the example project.
Related Issues
Checklist
Screenshots
N/A