Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix End Of Doc Crash#285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@thecoolwinter
Copy link
Collaborator

Description

Fixes a crash that occurred when editing the last characters in a file. This was missed by tests because it only appeared when syntax highlighting was applied.

Added a test case that catches this case in the styled range store. Added a second test in the highlighter tests that catches this and hopefully helps prevent some future bugs related to the highlighter.

Also added the package tests to the example app so tests can be run from the example project.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinterthecoolwinter self-assigned thisJan 6, 2025
@thecoolwinterthecoolwinter added the bugSomething isn't working labelJan 6, 2025
@thecoolwinterthecoolwinter merged commit63bae5a intoCodeEditApp:mainJan 7, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FastestMolassesFastestMolassesFastestMolasses approved these changes

@austincondiffaustincondiffAwaiting requested review from austincondiff

@0xWDG0xWDGAwaiting requested review from 0xWDG

@tom-ludwigtom-ludwigAwaiting requested review from tom-ludwig

Assignees

@thecoolwinterthecoolwinter

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thecoolwinter@FastestMolasses

[8]ページ先頭

©2009-2025 Movatter.jp