Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Correctly Lose Focus (finish CETV#14)#229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
thecoolwinter merged 1 commit intoCodeEditApp:mainfromthecoolwinter:fix-focus
Feb 4, 2024

Conversation

@thecoolwinter
Copy link
Collaborator

Description

Finishes the required changes to makeCodeEditTextView#14 work in CESE, once those changes are merged with a package update.

Removes the first responder acquisition when updating cursors, the text view should handle focus state and does so correctly on the main branch. Also fixes a small ordering bug with a check variable related to this issue.

Related Issues

  • CodeEditTextView issue, no issues created here.

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

Copy link
Member

@tom-ludwigtom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!
You probably know this, but you can use the trailing closure syntax on thesorted method.

Copy link
Collaborator

@0xWDG0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@thecoolwinter
Copy link
CollaboratorAuthor

LGTM! You probably know this, but you can use the trailing closure syntax on thesorted method.

Oh, very true! Didn't catch that.

@thecoolwinterthecoolwinter merged commit00bb66f intoCodeEditApp:mainFeb 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@0xWDG0xWDG0xWDG approved these changes

@tom-ludwigtom-ludwigtom-ludwig approved these changes

@austincondiffaustincondiffAwaiting requested review from austincondiff

@KaiTheRedNinjaKaiTheRedNinjaAwaiting requested review from KaiTheRedNinja

@luah5luah5Awaiting requested review from luah5

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thecoolwinter@0xWDG@tom-ludwig

[8]ページ先頭

©2009-2025 Movatter.jp