Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Auto focus text field when creating new files and folders#2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
FastestMolasses wants to merge8 commits intomain
base:main
Choose a base branch
Loading
fromfile-renaming

Conversation

@FastestMolasses
Copy link
Member

@FastestMolassesFastestMolasses commentedJul 25, 2025
edited
Loading

Description

When we create a new file or folder, CodeEdit will now automatically focus the renaming field so the user can directly set the file name in one step.

Files and folders are no longer created immediately, instead a "phantom" file will be represented in the project navigator, and will only actually create the file when the user sets a valid file name.

Lastly, we do not automatically set the file extension for the user.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

auto.rename.mov

@FastestMolassesFastestMolasses self-assigned thisJul 25, 2025
@FastestMolassesFastestMolasses added enhancementNew feature or request navigator labelsJul 25, 2025
@FastestMolassesFastestMolasses marked this pull request as draftJuly 25, 2025 08:02
@FastestMolassesFastestMolasses marked this pull request as ready for reviewJuly 25, 2025 18:56
@thecoolwinter
Copy link
Collaborator

This looks great, just needs the lint fix and we can merge!

@FastestMolasses
Copy link
MemberAuthor

@thecoolwinter Looks like just an unrelated issue with theCEActiveTaskTests test

@thecoolwinter
Copy link
Collaborator

I agree, I can't seem to track down why those tests are failing but they appear to be fixed on main. We can merge without those passing tests.

Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Found one bug. If there's a file system event while the new file item is focused, it silently fails to create the file.

Screen.Recording.2025-08-08.at.10.07.30.AM.mov

Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@thecoolwinterthecoolwinterthecoolwinter approved these changes

@austincondiffaustincondiffAwaiting requested review from austincondiff

@0xWDG0xWDGAwaiting requested review from 0xWDG

At least 2 approving reviews are required to merge this pull request.

Assignees

@FastestMolassesFastestMolasses

Labels

enhancementNew feature or requestnavigator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FastestMolasses@thecoolwinter

[8]ページ先頭

©2009-2025 Movatter.jp