NotificationsYou must be signed in to change notification settings
Fork1.1k
Star22.5k

Hide interface#2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

austincondiff merged 13 commits intoCodeEditApp:mainfromSimonKudsk:hide-interface

May 29, 2025

Merged

Hide interface#2044

austincondiff merged 13 commits intoCodeEditApp:mainfromSimonKudsk:hide-interface

May 29, 2025

Conversation

Copy link

Contributor

SimonKudsk commentedMay 13, 2025•
edited
Loading

Description

A "Hide interface" button within view settings has been added. To facilitate this, multiple changes have been made:

Added file "CodeEditWindowController+Panels.swift" with logic for hiding panels
Moved logic for toggling first and last panel from CodeEditWindowController.swift to CodeEditWindowController+Panels.swift.
Added possibility for SplitViewItems, first panel and last panel to be collapsed without animation
Added a specific command for the utility drawer to be opened without animation
Added Swift and Objective C specific functions for last panel and first panel toggling
Added "previous" variables of panel states within CodeEditWindowController.swift

The behavior of the hide interface button differs, depending on the current state of the interface, as per the description of the issue. The button will switch between hiding and showing the interface.

When showing:

If no panels are open, and no previous values are stored, all panels will open when toggling.
If no panels are open, and previous values are stored, the previous panels will open.
If some panels are open, and previous values are stored, it will open the remaining panels.

When hiding:

Current state of the interface is stored, and all elements are hidden.

When individual interface elements are toggled, the button will also update. If all elements are manually enabled, the button will change back to "Hide interface".

Related Issues

✨ Hide Interface #1632

Checklist

I read and understood thecontributing guide as well as thecode of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code

Screenshots

Screen.Recording.2025-05-13.at.23.17.12.mov

SimonKudsk added8 commits

May 6, 2025 17:27

Added initial hide interface button

b1fbbe5

- Hide interface and shortcut will store the interface state and hide it- Show interface will restore the interface state

Hiding interface now remembers better

52df185

- When hiding interface it will better be able to handle hidden elements being enabled, and then showing the interface again.- Moved some logic from ViewCommands to CodeEditWindowController, as it seems like a more appropriate place.- Added a bool shouldAnimate to function toggleFirstPanel. This is by default on, and thus using the default animation. When explicitly called with off, the function will not animate.

interfaceHidden will now update itself on changes

775ec99

- Removed need for interfaceHidden bool- Removed need for resetting stored interface state- Added function isInterfaceStillHidden, checking whether "at least" the previous elements are visible again, taking other elements into account- Hidden animation for lastpanel

Updated logic to when no panels are active

3f5cd70

- If no panels are active, and interface hasn't been hidden, all panels will show when toggle interface is clicked- Renamed objc functions with prefix 'objc'- Re-added resetStoredInterfaceCollapseState - turns out it was necessary

Merge branch 'CodeEditApp:main' into hide-interface

25f1681

Disabled animation for utility area when hiding interface

0ac2bae

- Added command "open.drawer.no.animation" to command manager. This will toggle the utility area, without an animation.- Added option possibility of no animation to SplitViewItem.Update- Added struct SplitViewItemCanAnimateViewTraitKey and function splitViewCanAnimate to SplitViewModifiers. These optionally allow disabling animations for SplitViews.- Updated "Hide Interface", WorkspaceView and UtilityAreaViewModel to accommodate these changes

Rewrote and moved hide interface logic

a3dadc7

- The logic for hide interface has been moved to a new file, CodeEditWindowsController+Panels.- The function for toggling first panel and last panel has also been moved to said file.- The logic for hide interface is now much more simplified, dynamic and easier to maintain.

Asynchronous reset of stored state

2ba29d9

- In isInterfaceStillHidden(), resetStoredInterfaceCollapseState() will now be called asynchronously to avoid a SwiftUI update warning

Copy link

Collaborator

austincondiff commentedMay 14, 2025•
edited
Loading

Beautiful! Nice work! I look forward to reviewing your implementation. It’s definitely a feature I’ve been wanting to do for a while now and haven’t got around to. I’m glad you were able to knock it out.

It does look like we have a failed test, take a look when you get a chance.

@CodeEditApp/maintainers I wonder if we can default hide interface to true in single file mode and open it as a n empty workspace so users can open a folder, add tabs, etc similar to other editors. Any thoughts around this?

SimonKudsk added2 commits

May 14, 2025 09:44

Removed comma

ecfdf70

- Removed a comma that was causing the "Testing CodeEdit" task to fail

Added UI Tests for HideInterfaceTest behaviour

7b205fb

Copy link

ContributorAuthor

SimonKudsk commentedMay 14, 2025

I took a look at the failed test, and resolved the issue. I also added some UI tests. They are a bit lengthy, but they cover the logic the different conditions the hide interface button might encounter. I'd appreciate feedback on these, specifically their format, or if there is a better approach you'd recommend.

Please note that there is no single "hide interface" bool. This functionality depends on saving the state of the panels, hiding them all, and then using the stored states to restore. The logic required for defaulting to hiding the interface in single file mode is therefore not covered by this PR as is - that would likely require hiding the panels individually.