Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Project Cleanup, Group to Folder Conversion, and SwiftLint Upgrade#2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@austincondiff
Copy link
Collaborator

@austincondiffaustincondiff commentedMar 4, 2025•
edited
Loading

Important

This is anemergency fix and is necessary for our test runner to work properly moving forward. That said, as always, please review carefully.

Description

Prepared project to use folders instead of groups by matching groups with filesystem.
Upgraded to SwiftLint 58 and fixed SwiftLint issues caused by the upgrade.
Converted Xcode groups to folders

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

lin72h reacted with thumbs up emojilin72h reacted with hooray emoji
@austincondiffaustincondiff changed the titleProject Cleanup and SwiftLint Upgradechore: Project Cleanup and SwiftLint UpgradeMar 4, 2025
@austincondiffaustincondiff self-assigned thisMar 4, 2025
FastestMolasses
FastestMolasses previously approved these changesMar 4, 2025
Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lots of little changes, want to make sure we aren't breaking anything so I've got a few clarifying questions.

austincondiff reacted with thumbs up emoji
@austincondiff
Copy link
CollaboratorAuthor

There is one last warning in ExtensionSceneView that I can't seem to figure out a solution to...

image

Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two quick remaining things related to reverting that URL+Identifiable change

@austincondiffaustincondiff changed the titlechore: Project Cleanup and SwiftLint Upgradechore: Project Cleanup, Group to Folder Conversion, and SwiftLint UpgradeMar 5, 2025
Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@thecoolwinter
Copy link
Collaborator

Good stuff, glad to have the CI runner updated and using folders will be so nice for dealing with conflicts.

austincondiff reacted with thumbs up emoji

@austincondiffaustincondiff merged commit1f6c33a intoCodeEditApp:mainMar 5, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FastestMolassesFastestMolassesFastestMolasses approved these changes

@thecoolwinterthecoolwinterthecoolwinter approved these changes

@tom-ludwigtom-ludwigAwaiting requested review from tom-ludwig

@0xWDG0xWDGAwaiting requested review from 0xWDG

@matthijseikelenboommatthijseikelenboomAwaiting requested review from matthijseikelenboom

Assignees

@austincondiffaustincondiff

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austincondiff@thecoolwinter@FastestMolasses
[8]ページ先頭
©2009-2025 Movatter.jp