Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: Tasks In Folder With Spaces#1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@thecoolwinter
Copy link
Collaborator

@thecoolwinterthecoolwinter commentedJan 29, 2025•
edited
Loading

Description

Fixes running tasks in folders with spaces by adding anescapedDirectory method toString that escapes quotes and places the directory in quotes.

/Path " / With Folder
becomes
"/Path " / With Folder"
So it can be safely used incd

Also updated a fewgit commands to correctly escape both quotes and whitespace.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before (note the git error on top of the failed task run):
Screenshot 2025-01-29 at 4 29 21 PM

After:
Screenshot 2025-01-29 at 4 30 00 PM

Copy link
Collaborator

@0xWDG0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@tom-ludwigtom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! We might want to start working on randomized tests—if we had them in place, we probably would have caught that earlier

@tom-ludwigtom-ludwig merged commitf24981a intoCodeEditApp:mainJan 30, 2025
2 checks passed
@thecoolwinter
Copy link
CollaboratorAuthor

Good catch! We might want to start working on randomized tests—if we had them in place, we probably would have caught that earlier

100% agreed. Having some tests for git would be a good idea as well. That reminds me I didn't implement any tests for this bug 🤦‍♂️

@thecoolwinterthecoolwinter added the bugSomething isn't working labelFeb 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@austincondiffaustincondiffaustincondiff approved these changes

@0xWDG0xWDG0xWDG approved these changes

@tom-ludwigtom-ludwigtom-ludwig approved these changes

@matthijseikelenboommatthijseikelenboomAwaiting requested review from matthijseikelenboom

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tasks break when the folder has a space in it

4 participants

@thecoolwinter@austincondiff@0xWDG@tom-ludwig
[8]ページ先頭
©2009-2025 Movatter.jp