Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

"Close Tabs to the Right" no longer closes the tab the action is performed on#1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@LeonardoLarranaga
Copy link
Contributor

@LeonardoLarranagaLeonardoLarranaga commentedOct 12, 2024•
edited
Loading

Description

Currently, CodeEdit closes the tab where "Close Tabs to the Right" was used on, this doesn't happen in Xcode.

Edit made: Just starts deleting fromindex + 1, verifying theindex + 1 exists.

(Also maybe we could add a close tabs to the left? I find myself in situations where it would be incredibly useful, although it doesn't exist in Xcode).

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

Screen.Recording.2024-10-11.at.19.14.49.mov

After:

Screen.Recording.2024-10-11.at.19.21.52.mov

@LeonardoLarranagaLeonardoLarranaga changed the titleFixes an issue where "Close Tabs to the Right" would also close the tab the action was performed on.Fixes an issue where "Close Tabs to the Right" would also close the tab the action was performed onOct 12, 2024
Copy link
Collaborator

@austincondiffaustincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch!

@austincondiffaustincondiff changed the titleFixes an issue where "Close Tabs to the Right" would also close the tab the action was performed on"Close Tabs to the Right" no longer closes the tab the action is performed onOct 12, 2024
@austincondiff
Copy link
Collaborator

One minor thing I notice is the tabs fade out when closed. In Xcode they do not.

Copy link
Member

@tom-ludwigtom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@austincondiffaustincondiff merged commitcb2fdb2 intoCodeEditApp:mainOct 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@austincondiffaustincondiffaustincondiff approved these changes

@tom-ludwigtom-ludwigtom-ludwig approved these changes

@0xWDG0xWDGAwaiting requested review from 0xWDG

@bombardier200bombardier200Awaiting requested review from bombardier200

@FastestMolassesFastestMolassesAwaiting requested review from FastestMolasses

@thecoolwinterthecoolwinterAwaiting requested review from thecoolwinter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonardoLarranaga@austincondiff@tom-ludwig
[8]ページ先頭
©2009-2025 Movatter.jp