Description

Fixes an issue discussed a few differenttimes with the navigator.

To reproduce:

• Enable "reveal in project navigator" setting.
• Select a file
• Using the arrow keys, move up or down to a folder in the navigator
• Eventually, the app will freeze.

This fixes that bug, and another one I found on the way.

In this PR:

• Add a few more cases whereshouldSendSelectionUpdate in the navigator outline view needed to be set. In these cases, extra selection events were being sent back to the navigator when a tab was opened. This was one of the reasons for the freeze as a few files were being opened over and over again.
• Removes a call toupdateSelection when receiving a notice that the directory monitor has updated. This was causing an issue where, when revealing a previously unloaded directory, the selection would jump back to the opened tab rather than staying on the folder being opened.
• Cleans up some of the editor history code, adding a few methods and moving as much history code as possible to an extension.

Related Issues

• Maybecloses🐞 Reveal in Project Navigator not working #1721.@austincondiff can you check if that's working now? In my quick check it was.

Checklist

• I read and understood thecontributing guide as well as thecode of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots