Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: Validate filenames consisting solely of extensions#1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
thecoolwinter merged 6 commits intoCodeEditApp:mainfromLeonardoLarranaga:main
Jul 11, 2024

Conversation

@LeonardoLarranaga
Copy link
Contributor

@LeonardoLarranagaLeonardoLarranaga commentedJul 9, 2024•
edited
Loading

Description

This pull request resolves an issue where supported files with only extensions (e.g., .env, .gitignore) were not displaying their correct icons.

Related Issues

Checklist

  • I read and understood thecontributing guide as well as thecode of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

icons file extensions error

After:

fixed pull request.env.local - .eslintrc.js fix

Leonardo Larrañaga added4 commitsJuly 8, 2024 20:00
0xWDG
0xWDG previously approved these changesJul 10, 2024
Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me, there is one edge case created by taking the first result. For instance this file should be a yaml file icon. Could you reverse the check? So we first check if there's a valid file extension, then do your check for the prefixed filename. Then if that all fails we do a txt file.

Screenshot 2024-07-10 at 5 50 58 PM

@LeonardoLarranaga
Copy link
ContributorAuthor

@thecoolwinter Working on it!

Leonardo Larrañaga added2 commitsJuly 10, 2024 17:38
Copy link
Collaborator

@thecoolwinterthecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perfect!

@thecoolwinterthecoolwinter merged commit8e098b6 intoCodeEditApp:mainJul 11, 2024
@thecoolwinter
Copy link
Collaborator

@allcontributors please add@LeonardoLarranaga for code

@allcontributors
Copy link
Contributor

@thecoolwinter

I've put upa pull request to add@LeonardoLarranaga! 🎉

@austincondiffaustincondiff added the enhancementNew feature or request labelJul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bombardier200bombardier200bombardier200 approved these changes

@0xWDG0xWDG0xWDG left review comments

@austincondiffaustincondiffAwaiting requested review from austincondiff

@matthijseikelenboommatthijseikelenboomAwaiting requested review from matthijseikelenboom

@thecoolwinterthecoolwinterAwaiting requested review from thecoolwinter

@tom-ludwigtom-ludwigAwaiting requested review from tom-ludwig

+1 more reviewer

@nanashilinanashilinanashili left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or requestnavigator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Icons not displayed correctly for files with only extensions

6 participants

@LeonardoLarranaga@thecoolwinter@0xWDG@bombardier200@nanashili@austincondiff
[8]ページ先頭
©2009-2025 Movatter.jp