Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
Stop Modifying User's RC Files#1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bombardier200 merged 2 commits intoCodeEditApp:mainfromthecoolwinter:fix/modifying-users-intifilesJun 13, 2024
Merged
Stop Modifying User's RC Files#1753
bombardier200 merged 2 commits intoCodeEditApp:mainfromthecoolwinter:fix/modifying-users-intifilesJun 13, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
FastestMolasses approved these changesJun 13, 2024
bombardier200 approved these changesJun 13, 2024
Contributor
bombardier200 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great work! Always good to fix a privacy issue!
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates our terminal integration to be a little more clever about injections. Introduces a
ShellIntegrationenum, which contains functions for setting up a pseudo terminal for supported shells.Introduces a method for each shell for injecting our pre/post exec handlers:
zsh.zshinjection files into that temp folder..zshinjection file is an override for zsh's real init files (.zprofile,.zshenv,.zshrc,.zlogin).zdotdirenv variable and store it, replacing it with our own pointing to the temporary directory..zshXfiles, we source the user's real zsh init files exactly how zsh does it..zshrc, we do our injection code.bash--init-fileparameter for bash. Creating a new, interactive session using our own init file..bashrcdepending on if the session is a login session.These borrow some MIT-licensed code from VSCode and are documented as such, with permalinks to the source files.
Finally, because we're doing this at runtime we can allow users to opt-out of the injection mechanism in settings.
Related Issues
Checklist
Screenshots
Before (zsh example):
Screen.Recording.2024-06-12.at.4.48.06.PM.mov
After: init files still being sourced, not modifying the user's init files, and terminal titles still working.
Zsh:
Screen.Recording.2024-06-12.at.5.10.11.PM.mov
Bash:
Screen.Recording.2024-06-12.at.5.08.26.PM.mov