Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
Correctly preview non-text files#1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Correctly preview non-text files#1707
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…s from the parent Group view
…t work around- the first play click doesn't start the video, but the audio starts playing in the background, even after closing the editor tab- and everything in-between
- NonTextFileView, OtherFileView, URL+isImage, are not needed anymore
- also added the view to the App Window docs
- `WorkspaceAnyFileView` -> `AnyFileView`- `WorkspaceLoadingView` -> `LoadingFileView`- `WorkspaceImageView` -> `ImageFileView`- `WorkspacePDFView` -> `PDFFileView`
8069cbc todda4d34Compare- this removes the need to check for GIF images- this also has a nice add-on of using gestures for zoom
dda4d34 tob373bb6Comparethecoolwinter commentedMay 10, 2024
Looks like there's an issue with our CI, it might need an update, which would explain the failing test. |
austincondiff commentedMay 10, 2024
Nice work! I can't pull it down now but just so you are aware, images should show full pixels (not scaled up to fit if smaller than window). If it is too big for the window it should scale down to fit. We could later add some small controls to adjust the zoom levels and have buttons for 1x, 2x, and 3x. |
plbstl commentedMay 11, 2024
Yes, this PR does that. Implementing it was really hard for me and it took the most time, but I'm happy it did so without a really complex logic. |
austincondiff left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perfect! Excellent work!
austincondiff commentedMay 11, 2024
@allcontributors add@plbstl for bug |
I've put upa pull request to add@plbstl! 🎉 |
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR allows CodeEdit to preview non text files correctly.
All the file formats in the related issue#1698 were tested.
Related Issues
Checklist
Screenshots
QuickLook doesn't load until the Git branch shows up:
code-edit-view-file1.mov