Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: distinguish between Move to Trash and Delete Immediately when right clicking a file or folder.#1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfromplbstl:fix/distinguish-between-trash-and-delete-file-folderMay 1, 2024
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ght clicking a file or folder
Collaborator
austincondiff commentedApr 30, 2024
Excellent work@plbstl! Reviewing this now. |
FastestMolasses requested changesApr 30, 2024
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+FileManagement.swift OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Contributor
knotbin commentedMay 1, 2024
@FastestMolasses could you rereview this? There's an issue I want to work on that would conflict with this PR |
FastestMolasses approved these changesMay 1, 2024
thecoolwinter approved these changesMay 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basically what the PR title says.
This PR fixes the issue when deleting a file is not as predictable.
Right click a file or folder to see Move to Trash, and this moves the file or folder to trash.
Holding Option while the context menu is open will change the option to "Delete Immediately...", which deletes the file or folder immediately.
Related Issues
closes#1693
Checklist
Screenshots
Before:
code-edit.bug.move.to.trash.mov
After:
code-edit.fix.move.to.trash.mov