NotificationsYou must be signed in to change notification settings
Fork1.1k
Star22.5k

keyboard shortcut for tab switching#1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

austincondiff merged 3 commits intoCodeEditApp:mainfromknotbin:main

Apr 22, 2024

Merged

keyboard shortcut for tab switching#1677

austincondiff merged 3 commits intoCodeEditApp:mainfromknotbin:main

Apr 22, 2024

Conversation

Copy link

Contributor

knotbin commentedApr 21, 2024•
edited
Loading

Description

The following keyboard shortcuts are now implemented:
CMD + SHIFT + ] to go to the next tab or, if the user is on the last tab, wrap around to the first tab
CMD + SHIFT + [ to go to the previous tab or, if the user is on the first tab, wrap around to the last tab

Related Issues

closes✨ ⇧⌘[ and ⇧⌘] keyboard shortcuts to cycle between editor tabs in the active editor #1658

Checklist

I read and understood thecontributing guide as well as thecode of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code

Screenshots

keyboard shortcut for tab switching

a09eaf7

austincondiff self-requested a review

April 22, 2024 13:37

austincondiff requested changes

Apr 22, 2024

View reviewed changes

Copy link

Collaborator

austincondiff left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fantastic work! There are a few small adjustments we need to make in order to merge this.

These keyboard shortcuts should probably be associated with menu items instead of empty buttons...

Navigate > Show Previous Tab
Navigate > Show Next Tab

These currently exist but are disabled so all you should need to do is hook them up to the functions you wrote.

We also need to make sure that this is only applied to the focused editor and not applied to all open editors if the user has a split editor layout.

extension and menu bar

5aff25f

Copy link

ContributorAuthor

knotbin commentedApr 22, 2024

Thanks so much for all the feedback and sorry for the incredibly janky initial workaround. I just fixed the menu bar implementation by adding an extension to the editor with the functions I made and using those in the NavigateCommands. Because NavigateCommands uses @FocusedObject, it only tabs the focused split now. Tell me if you want anything else changed or fixed and thanks again for the feedback.