Commit2bb2c48

asmorkalov

authored and

thewoz

committed

Merge pull requestopencv#26080 from asmorkalov:as/HAL_minMaxIdx_ND_offset

Added offset for HAL as ofs2idx expects 1-based indexopencv#26080### Pull Request Readiness ChecklistSee details athttps://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request- [x] I agree to contribute to the project under Apache 2 License.- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV- [ ] The PR is proposed to the proper branch- [ ] There is a reference to the original bug report and related work- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.- [ ] The feature is well documented and sample code can be built with the project CMake

1 parentf9e666e commit2bb2c48Copy full SHA for 2bb2c48

File tree

1 file changed

-2

lines changed

modules/core/src
- minmax.cpp

1 file changed

-2

lines changed

`‎modules/core/src/minmax.cpp‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -846,6 +846,8 @@ static MinMaxIdxFunc getMinmaxTab(int depth)`
`846`	`846`	`return minmaxTab[depth];`
`847`	`847`	`}`
`848`	`848`
	`849`	`+// The function expects 1-based indexing for ofs`
	`850`	`+// Zero is treated as invalid offset (not found)`
`849`	`851`	`staticvoidofs2idx(const Mat& a,size_t ofs,int* idx)`
`850`	`852`	`{`
`851`	`853`	`int i, d = a.dims;`
`@@ -1524,9 +1526,9 @@ void cv::minMaxIdx(InputArray _src, double* minVal,`
`1524`	`1526`	`{`
`1525`	`1527`	`// minIdx[0] and minIdx[0] are always 0 for "flatten" version`
`1526`	`1528`	`if (minIdx)`
`1527`		`-ofs2idx(src, minIdx[1], minIdx);`
	`1529`	`+ofs2idx(src, minIdx[1]+1, minIdx);`
`1528`	`1530`	`if (maxIdx)`
`1529`		`-ofs2idx(src, maxIdx[1], maxIdx);`
	`1531`	`+ofs2idx(src, maxIdx[1]+1, maxIdx);`
`1530`	`1532`	`return;`
`1531`	`1533`	`}`
`1532`	`1534`	`elseif (res != CV_HAL_ERROR_NOT_IMPLEMENTED)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2bb2c48

File tree

1 file changed

1 file changed

`‎modules/core/src/minmax.cpp‎`

0 commit comments