- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix finalized buffer issue on windows aggregation operations#92395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Ergus wants to merge1 commit intoClickHouse:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+38 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Finalized buffers can't be reset, so they need to be also reconstructed.On Windows execution insertResultInto needs to call buffer finalization to compute size on every iteration.But in the next iteration the buffer needs reconstruction.
clickhouse-ghbot commentedDec 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Workflow [PR], commit [c323ca2] Summary: ⏳
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalized buffers can't be reset, so they need to be also reconstructed.
Fixes:#91415
On Windows execution insertResultInto needs to call buffer finalization to compute size on every iteration. But in the next iteration the buffer needs reconstruction.
Changelog category (leave one):
Changelog entry (auser-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes