- Notifications
You must be signed in to change notification settings - Fork77
WIP: Helpers keep default config for robustness#195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:cake4-bs4-1.0.0
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedNov 16, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## cake4-bs4-1.0.0 #195 +/- ##=====================================================+ Coverage 86.63% 87.32% +0.68%- Complexity 380 382 +2===================================================== Files 19 19 Lines 1190 1183 -7 =====================================================+ Hits 1031 1033 +2+ Misses 159 150 -9
Continue to review full report at Codecov.
|
| * @return string The classes for the size or offset of the specified column. | ||
| */ | ||
| protectedfunction_getColumnClass(string$what):string | ||
| publicfunctiongetColumnClass(string$what):string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there any reason for this to be madepublic? And the_ prefix is CakePHP convention for protected methods, any reason you removed it from most methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My phpcs was misconfigured in my IDE. Sorry
| { | ||
| // Standard form | ||
| $this->assertHtml([ | ||
| self::assertHtml([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Any reason for this?
It's a try to prevent addition in Cake helpers will break the code.
Bootstrap helper is in
$helperConfigand merged to$_defaultConfig. This way, templates and widgets always have a correct default and follow framework.Work in progress, need to do all helpers if good way.