- Notifications
You must be signed in to change notification settings - Fork77
force UrlComparerTrait::_normalize to use GET method#180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:4.0.1-alpha
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Erwane commentedJul 9, 2019
for issue#179 |
Holt59 commentedJul 9, 2019
Thanks for the PR. Isn't this going to break the opposite case, i.e., if you have a POST URL and you are on a GET one? |
Erwane commentedJul 9, 2019
There is no reason a POST only route need UrlComparerTrait for navlinks i thinks. Maybe in case of ajax url in Another option is to parse RouteCollection and check url only for route allow current method ? |
Holt59 commentedJul 9, 2019
I agree with you regarding POST only links in a navigation bar but I would like the Honestly, I don't know why CakePHP has such behaviour... |
Erwane commentedOct 15, 2019
Hi. |
Holt59 commentedOct 16, 2019
@Erwane A possibility would be to let user specify the method used to compare, with a default to no-method in the This would be retro-compatible, and more flexible for future changes. |
No description provided.