Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BB2-2681 SMART app launch Inferno Testing PROTOTYPE#1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dtisza1 wants to merge2 commits intomaster
base:master
Choose a base branch
Loading
fromdtisza1/BB2-2681-smart-on-fhir-testing1

Conversation

@dtisza1
Copy link
Contributor

JIRA Ticket:
BB2-2681

User Story or Bug Summary:

This is a prototype PR created from testing the SMART app launch compatibility. The Inferno tool was used for testing.

DO NOT MERGE!

What Does This PR Do?

This adds a /.well-known/smart-configuration endpoint to the API. This is used for SMART app launch discovery purposes.

For testing results, see the report in the Jira ticket's comments.

What Should Reviewers Watch For?

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below isYes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies?No.
    • Does this PR modify or invalidate any of our security controls?No.
    • Does this PR store or transmit data that was not stored or transmitted before?No.
  • If the answer to any of the questions below isYes, then please add StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons?No.

What Needs to Be Merged and Deployed Before this PR?

DO NOT MERGE!

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per:https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, includingREADME updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed inTODO and/orFIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in theDASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@dtisza1dtisza1 added WIPWork in progress POC DO NOT merge labelsOct 12, 2023
@dtisza1dtisza1 requested a review fromajshredOctober 12, 2023 13:55
@dtisza1dtisza1 self-assigned thisOct 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ajshredajshredAwaiting requested review from ajshred

At least 1 approving review is required to merge this pull request.

Assignees

@dtisza1dtisza1

Labels

POC DO NOT mergeWIPWork in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtisza1

[8]ページ先頭

©2009-2025 Movatter.jp