- Notifications
You must be signed in to change notification settings - Fork9
Open
Description
I believe theif !ok check in the bottom of this snippet is inaccessible and therfore not required, due to the check forentity.tag.matches(tag) prior to it. I cannot come up with a situation in which the first tag check would pass but the attempt to get component data would fail. Is this correct? Code inserted below for your reference:
func (manager*Manager)fetchComponentsForEntity(entity*Entity,tagTag)map[*Component]interface{} {if!entity.tag.matches(tag) {returnnil}componentMap:=make(map[*Component]interface{})for_,component:=rangemanager.components {iftag.matches(component.tag) {data,ok:=entity.GetComponentData(component)if!ok {returnnil// if one of the required components is not set, return nothing !}```
Metadata
Metadata
Assignees
Labels
No labels