Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Pagination#144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ManorSailor wants to merge3 commits intoBuzzpy:master
base:master
Choose a base branch
Loading
fromManorSailor:pagination
Draft

Conversation

@ManorSailor
Copy link
Contributor

@ManorSailorManorSailor commentedSep 16, 2024
edited
Loading

Closes#15

Bugs:

  • Search is broken.

Suggestions Needed:

  • Should we add a Homepage that displays a few cards, along with a link to page 1 of the terms?
  • Regarding the Search feature, I’m open to suggestions, as I currently don’t have a clear idea on how to fix it.

Tradeoffs:

  • I decided to keep the pagination buttons (previous & next) visible in their respective edge cases (previous button visible on the first page, and next button visible on the last page) instead of conditionally rendering them. This is because conditionally rendering was causing styling issues when an element was absent from the page.
  • Initially, I considered disabling the a tags; however, since they don't support the disabled attribute, I added a new style to disable them via CSS. This is, perhaps, not the most accessible approach.
  • I also decided to keep the root route, i.e., the homepage, intact even though it currently lacks any content. This will make it easier to add a homepage in the future.

@ManorSailorManorSailor changed the titlePagination Supportfeat: PaginationSep 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pagination (suggestion)

1 participant

@ManorSailor

[8]ページ先頭

©2009-2025 Movatter.jp