- Notifications
You must be signed in to change notification settings - Fork1.1k
Fix LSTM training continuity for cloned nets#951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
rizmyabdulla wants to merge1 commit intoBrainJS:masterChoose a base branch fromrizmyabdulla:fix-lstm-training
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
FixesBrainJS#949Update `src/recurrent.ts` to ensure cloned LSTM nets continue training from the point where the original stopped.* Add `fromJSON` method to properly restore the training state.* Modify `train` method to account for the state of the cloned net.* Update `trainPattern` method to consider the previous training state of the cloned net.* Adjust `initialize` method to handle state restoration for cloned nets.* Ensure `runInputs` method maintains continuity in training for cloned nets.Add a test case in `src/recurrent/lstm.test.ts` to verify that training a cloned LSTM net continues evolving from the point where the original stopped.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#949
Update
src/recurrent.ts
to ensure cloned LSTM nets continue training from the point where the original stopped.fromJSON
method to properly restore the training state.train
method to account for the state of the cloned net.trainPattern
method to consider the previous training state of the cloned net.initialize
method to handle state restoration for cloned nets.runInputs
method maintains continuity in training for cloned nets.Add a test case in
src/recurrent/lstm.test.ts
to verify that training a cloned LSTM net continues evolving from the point where the original stopped.