- Notifications
You must be signed in to change notification settings - Fork407
Avoid leaking uv_async_t in Dispatcher::Deactivate()#1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mszabo-wikia wants to merge1 commit intoBlizzard:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
On disconnect, Dispatcher::Deactivate() calls uv_close() to close itsactive uv_async_t instance and nulls out the corresponding field,but never frees the underlying memory.To reproduce, run the following with node-rdkafka and librdkafkacompiled with ASAN:```jsconst { KafkaConsumer } = require('../');const consumer = new KafkaConsumer({ 'group.id': 'kafka', 'metadata.broker.list': 'localhost:9092',}, {});consumer.connect({ timeout: 2000 }, function (err) { if (err) { console.error('Error connecting to Kafka:', err); return; } consumer.disconnect();})```This should report:```Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x7f049c3aa647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99Blizzard#1 0x7f0471d872a1 in NodeKafka::Callbacks::Dispatcher::Activate() ../src/callbacks.cc:69Blizzard#2 0x7f0471e75c06 in NodeKafka::Workers::KafkaConsumerConnect::HandleOKCallback() ../src/workers.cc:579Blizzard#3 0x7f0471dd679c in Nan::AsyncWorker::WorkComplete() ../node_modules/nan/nan.h:2008Blizzard#4 0x7f0471dd679c in Nan::AsyncExecuteComplete(uv_work_s*) ../node_modules/nan/nan.h:2365Blizzard#5 0x7f0471dd679c in Nan::AsyncExecuteComplete(uv_work_s*, int) ../node_modules/nan/nan.h:2369Blizzard#6 0x18bb75c in uv__work_done ../deps/uv/src/threadpool.c:329Blizzard#7 0x18bf0b2 in uv__async_io ../deps/uv/src/unix/async.c:176Blizzard#8 0x18d3b2a in uv__io_poll ../deps/uv/src/unix/linux.c:1485Blizzard#9 0x18bfdd6 in uv_run ../deps/uv/src/unix/core.c:447Blizzard#10 0xbc9be5 in node::SpinEventLoopInternal(node::Environment*) (/usr/bin/node+0xbc9be5)Blizzard#11 0xd1d920 in node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [clone .part.0] (/usr/bin/node+0xd1d920)Blizzard#12 0xd1e38c in node::NodeMainInstance::Run() (/usr/bin/node+0xd1e38c)Blizzard#13 0xc710be in node::Start(int, char**) (/usr/bin/node+0xc710be)Blizzard#14 0x7f049bdf0d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)```The [libuv documentation](https://docs.libuv.org/en/v1.x/handle.html#c.uv_close)says it's only safe to free the underlying memory in a close callbackpassed to uv_close(), or after such a callback has returned. So, use aunique_ptr with a custom deleter to accomplish this.ottomata commentedJul 24, 2025
@GaryWilber@aryamohanan Is there anything we can do to expedite this one? It is likely causing a memory leak application restart issue at Wikimedia. Thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On disconnect, Dispatcher::Deactivate() calls uv_close() to close its active uv_async_t instance and nulls out the corresponding field, but never frees the underlying memory.
To reproduce, run the following with node-rdkafka and librdkafka compiled with ASAN:
This should report:
Thelibuv documentation says it's only safe to free the underlying memory in a close callback passed to uv_close(), or after such a callback has returned. So, use a unique_ptr with a custom deleter to accomplish this.