Commitf3749a2

committed

Solved the classcast exception and used instanceof instead. Improved javadocs a bit.

1 parent9e56e5c commitf3749a2Copy full SHA for f3749a2

File tree

+14

-12

lines changed

+14

-12

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,9 @@`
`23`	`23`	`packagecom.iluwatar.acyclicvisitor;`
`24`	`24`
`25`	`25`	`/**`
`26`		`- * All ModemVisitor interface extends all visitor interfaces`
	`26`	`+ * All ModemVisitor interface extends all visitor interfaces. This interface`
	`27`	`+ * provides ease of use when a visitor needs to visit all modem types.`
`27`	`28`	`*/`
`28`		`-publicinterfaceAllModemVisitorextendsModemVisitor,ZoomVisitor,HayesVisitor{`
	`29`	`+publicinterfaceAllModemVisitorextendsZoomVisitor,HayesVisitor{`
`29`	`30`
`30`	`31`	`}`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,10 @@`
`27`	`27`
`28`	`28`	`/**`
`29`	`29`	`* ConfigureForUnixVisitor class implements zoom's visit method for Unix`
`30`		`- * manufacturer`
	`30`	`+ * manufacturer, unlike traditional visitor pattern, this class may selectively implement`
	`31`	`+ * visit for other modems.`
`31`	`32`	`*/`
`32`		`-publicclassConfigureForUnixVisitorimplementsModemVisitor,ZoomVisitor {`
	`33`	`+publicclassConfigureForUnixVisitorimplementsZoomVisitor {`
`33`	`34`
`34`	`35`	`privatestaticfinalLoggerLOGGER =LoggerFactory.getLogger(ConfigureForUnixVisitor.class);`
`35`	`36`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ public class Hayes extends Modem {`
`37`	`37`	`*/`
`38`	`38`	`@Override`
`39`	`39`	`publicvoidaccept(ModemVisitormodemVisitor) {`
`40`		`-try {`
`41`		`- ((HayesVisitor)modemVisitor).visit(this);`
`42`		`- }catch (ClassCastExceptione) {`
`43`		`-LOGGER.error("Unable to casttoHayesVisitor");`
	`40`	`+if (modemVisitorinstanceofHayesVisitor) {`
	`41`	`+((HayesVisitor)modemVisitor).visit(this);`
	`42`	`+ }else {`
	`43`	`+LOGGER.info("Only HayesVisitor is allowedtovisit Hayes modem");`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`}`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ public class Zoom extends Modem {`
`37`	`37`	`*/`
`38`	`38`	`@Override`
`39`	`39`	`publicvoidaccept(ModemVisitormodemVisitor) {`
`40`		`-try {`
`41`		`- ((ZoomVisitor)modemVisitor).visit(this);`
`42`		`- }catch (ClassCastExceptione) {`
`43`		`-LOGGER.error("Unable to casttoZoomVisitor");`
	`40`	`+if (modemVisitorinstanceofZoomVisitor) {`
	`41`	`+((ZoomVisitor)modemVisitor).visit(this);`
	`42`	`+ }else {`
	`43`	`+LOGGER.info("Only ZoomVisitor is allowedtovisit Zoom modem");`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`

Comments

(0)