Commitdabe4d2

committed

Fix sonar issues

1 parentaff7ef8 commitdabe4d2Copy full SHA for dabe4d2

File tree

+17

-15

lines changed

+17

-15

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -85,13 +85,14 @@ public static void main(final String[] args) {`
`85`	`85`	`// installed and socket connection is open).`
`86`	`86`	`Appapp =newApp(isDbMongo(args));`
`87`	`87`	`app.useReadAndWriteThroughStrategy();`
`88`		`-System.out.println("==============================================");`
	`88`	`+StringsplitLine ="==============================================";`
	`89`	`+LOGGER.info(splitLine);`
`89`	`90`	`app.useReadThroughAndWriteAroundStrategy();`
`90`		`-System.out.println("==============================================");`
	`91`	`+LOGGER.info(splitLine);`
`91`	`92`	`app.useReadThroughAndWriteBehindStrategy();`
`92`		`-System.out.println("==============================================");`
	`93`	`+LOGGER.info(splitLine);`
`93`	`94`	`app.useCacheAsideStategy();`
`94`		`-System.out.println("==============================================");`
	`95`	`+LOGGER.info(splitLine);`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`/**`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@`
`26`	`26`	`importjava.util.Optional;`
`27`	`27`
`28`	`28`	`importcom.iluwatar.caching.database.DbManager;`
	`29`	`+importlombok.Data;`
`29`	`30`	`importlombok.extern.slf4j.Slf4j;`
`30`	`31`
`31`	`32`	`/**`
`@@ -37,11 +38,12 @@`
`37`	`38`	`* appropriate function in the CacheStore class.`
`38`	`39`	`*/`
`39`	`40`	`@Slf4j`
	`41`	`+@Data`
`40`	`42`	`publicclassAppManager {`
`41`	`43`	`/**`
`42`	`44`	`* Caching Policy.`
`43`	`45`	`*/`
`44`		`-privatestaticCachingPolicycachingPolicy;`
	`46`	`+privateCachingPolicycachingPolicy;`
`45`	`47`	`/**`
`46`	`48`	`* Database Manager.`
`47`	`49`	`*/`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,11 @@ public class CacheStore {`
`43`	`43`	`/**`
`44`	`44`	`* Lru cache see {@link LruCache}.`
`45`	`45`	`*/`
`46`		`-privatestaticLruCachecache;`
	`46`	`+privateLruCachecache;`
`47`	`47`	`/**`
`48`	`48`	`* DbManager.`
`49`	`49`	`*/`
`50`		`-privateDbManagerdbManager;`
	`50`	`+privatefinalDbManagerdbManager;`
`51`	`51`
`52`	`52`	`/**`
`53`	`53`	`* Cache Store.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public UserAccount readFromDb(final String userId) {`
`45`	`45`	`variterable =db`
`46`	`46`	`.getCollection(CachingConstants.USER_ACCOUNT)`
`47`	`47`	`.find(newDocument(USER_ID,userId));`
`48`		`-if (iterable ==null) {`
	`48`	`+if (iterable.first()==null) {`
`49`	`49`	`returnnull;`
`50`	`50`	`}`
`51`	`51`	`Documentdoc =iterable.first();`

Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,14 +13,14 @@ public class VirtualDb implements DbManager {`
`13`	`13`	`/**`
`14`	`14`	`* Virtual DataBase.`
`15`	`15`	`*/`
`16`		`-privateMap<String,UserAccount>virtualDB;`
	`16`	`+privateMap<String,UserAccount>db;`
`17`	`17`
`18`	`18`	`/**`
`19`	`19`	`* Creates new HashMap.`
`20`	`20`	`*/`
`21`	`21`	`@Override`
`22`	`22`	`publicvoidconnect() {`
`23`		`-virtualDB =newHashMap<>();`
	`23`	`+db =newHashMap<>();`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`/**`
`@@ -30,8 +30,8 @@ public void connect() {`
`30`	`30`	`*/`
`31`	`31`	`@Override`
`32`	`32`	`publicUserAccountreadFromDb(finalStringuserId) {`
`33`		`-if (virtualDB.containsKey(userId)) {`
`34`		`-returnvirtualDB.get(userId);`
	`33`	`+if (db.containsKey(userId)) {`
	`34`	`+returndb.get(userId);`
`35`	`35`	`}`
`36`	`36`	`returnnull;`
`37`	`37`	`}`
`@@ -43,7 +43,7 @@ public UserAccount readFromDb(final String userId) {`
`43`	`43`	`*/`
`44`	`44`	`@Override`
`45`	`45`	`publicUserAccountwriteToDb(finalUserAccountuserAccount) {`
`46`		`-virtualDB.put(userAccount.getUserId(),userAccount);`
	`46`	`+db.put(userAccount.getUserId(),userAccount);`
`47`	`47`	`returnuserAccount;`
`48`	`48`	`}`
`49`	`49`
`@@ -54,8 +54,7 @@ public UserAccount writeToDb(final UserAccount userAccount) {`
`54`	`54`	`*/`
`55`	`55`	`@Override`
`56`	`56`	`publicUserAccountupdateDb(finalUserAccountuserAccount) {`
`57`		`-virtualDB.put(userAccount.getUserId(),userAccount);`
`58`		`-returnuserAccount;`
	`57`	`+returnwriteToDb(userAccount);`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`/**`

Comments

(0)