Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitb423002

Browse files
authored
updated Random() to SecureRandom() (iluwatar#1670)
* updated Random() to SecureRandom()* batch 2 of SecureRandom updates
1 parentc150871 commitb423002

File tree

15 files changed

+32
-31
lines changed

15 files changed

+32
-31
lines changed

‎commander/src/main/java/com/iluwatar/commander/Order.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
packagecom.iluwatar.commander;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.Hashtable;
27-
importjava.util.Random;
2828

2929
/**
3030
* Order class holds details of the order.
@@ -45,7 +45,7 @@ enum MessageSent {
4545
publicfinalStringid;
4646
finalfloatprice;
4747
finallongcreatedTime;
48-
privatestaticfinalRandomRANDOM =newRandom();
48+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
4949
privatestaticfinalStringALL_CHARS ="ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";
5050
privatestaticfinalHashtable<String,Boolean>USED_IDS =newHashtable<String,Boolean>();
5151
PaymentStatuspaid;

‎commander/src/main/java/com/iluwatar/commander/Retry.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323

2424
packagecom.iluwatar.commander;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.ArrayList;
2728
importjava.util.Arrays;
2829
importjava.util.List;
29-
importjava.util.Random;
3030
importjava.util.concurrent.atomic.AtomicInteger;
3131
importjava.util.function.Predicate;
3232

@@ -56,7 +56,7 @@ public interface HandleErrorIssue<T> {
5656
voidhandleIssue(Tobj,Exceptione);
5757
}
5858

59-
privatestaticfinalRandomRANDOM =newRandom();
59+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
6060

6161
privatefinalOperationop;
6262
privatefinalHandleErrorIssue<T>handleError;

‎commander/src/main/java/com/iluwatar/commander/Service.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@
2424
packagecom.iluwatar.commander;
2525

2626
importcom.iluwatar.commander.exceptions.DatabaseUnavailableException;
27+
28+
importjava.security.SecureRandom;
2729
importjava.util.ArrayList;
2830
importjava.util.Hashtable;
2931
importjava.util.List;
30-
importjava.util.Random;
3132

3233
/**
3334
* Service class is an abstract class extended by all services in this example. They all have a
@@ -42,7 +43,7 @@ public abstract class Service {
4243

4344
protectedfinalDatabasedatabase;
4445
publicArrayList<Exception>exceptionsList;
45-
privatestaticfinalRandomRANDOM =newRandom();
46+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
4647
privatestaticfinalStringALL_CHARS ="ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";
4748
privatestaticfinalHashtable<String,Boolean>USED_IDS =newHashtable<>();
4849

‎event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/EventManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
packagecom.iluwatar.event.asynchronous;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.Map;
27-
importjava.util.Random;
2828
importjava.util.concurrent.ConcurrentHashMap;
2929

3030
/**
@@ -43,7 +43,7 @@ public class EventManager implements ThreadCompleteListener {
4343
publicstaticfinalintMAX_ID =MAX_RUNNING_EVENTS;
4444
publicstaticfinalintMAX_EVENT_TIME =1800;// in seconds / 30 minutes.
4545
privateintcurrentlyRunningSyncEvent = -1;
46-
privatefinalRandomrand;
46+
privatefinalSecureRandomrand;
4747
privatefinalMap<Integer,Event>eventPool;
4848

4949
privatestaticfinalStringDOES_NOT_EXIST =" does not exist.";
@@ -52,7 +52,7 @@ public class EventManager implements ThreadCompleteListener {
5252
* EventManager constructor.
5353
*/
5454
publicEventManager() {
55-
rand =newRandom(1);
55+
rand =newSecureRandom();
5656
eventPool =newConcurrentHashMap<Integer,Event>(MAX_RUNNING_EVENTS);
5757

5858
}

‎game-loop/src/main/java/com/iluwatar/gameloop/GameLoop.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
packagecom.iluwatar.gameloop;
2525

26-
importjava.util.Random;
26+
importjava.security.SecureRandom;
2727
importorg.slf4j.Logger;
2828
importorg.slf4j.LoggerFactory;
2929

@@ -80,7 +80,7 @@ public boolean isGameRunning() {
8080
*/
8181
protectedvoidprocessInput() {
8282
try {
83-
varlag =newRandom().nextInt(200) +50;
83+
varlag =newSecureRandom().nextInt(200) +50;
8484
Thread.sleep(lag);
8585
}catch (InterruptedExceptione) {
8686
logger.error(e.getMessage());

‎hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryNumbers.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
packagecom.iluwatar.hexagonal.domain;
2525

2626
importcom.google.common.base.Joiner;
27+
importjava.security.SecureRandom;
2728
importjava.util.Collections;
2829
importjava.util.HashSet;
2930
importjava.util.PrimitiveIterator;
30-
importjava.util.Random;
3131
importjava.util.Set;
3232

3333
/**
@@ -126,7 +126,7 @@ private static class RandomNumberGenerator {
126126
* @param max the max value (inclusive)
127127
*/
128128
publicRandomNumberGenerator(intmin,intmax) {
129-
randomIterator =newRandom().ints(min,max +1).iterator();
129+
randomIterator =newSecureRandom().ints(min,max +1).iterator();
130130
}
131131

132132
/**

‎hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030
importcom.iluwatar.hexagonal.domain.LotteryTicket;
3131
importcom.iluwatar.hexagonal.domain.LotteryTicketId;
3232
importcom.iluwatar.hexagonal.domain.PlayerDetails;
33+
importjava.security.SecureRandom;
3334
importjava.util.AbstractMap.SimpleEntry;
3435
importjava.util.List;
35-
importjava.util.Random;
3636
importjava.util.stream.Collectors;
3737

3838
/**
@@ -41,7 +41,7 @@
4141
publicclassSampleData {
4242

4343
privatestaticfinalList<PlayerDetails>PLAYERS;
44-
privatestaticfinalRandomRANDOM =newRandom();
44+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
4545

4646
static {
4747
PLAYERS =List.of(

‎leader-followers/src/main/java/com/iluwatar/leaderfollowers/App.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
packagecom.iluwatar.leaderfollowers;
2525

26-
importjava.util.Random;
26+
importjava.security.SecureRandom;
2727
importjava.util.concurrent.Executors;
2828
importjava.util.concurrent.TimeUnit;
2929

@@ -84,7 +84,7 @@ private static void execute(WorkCenter workCenter, TaskSet taskSet) throws Inter
8484
* Add tasks.
8585
*/
8686
privatestaticvoidaddTasks(TaskSettaskSet)throwsInterruptedException {
87-
varrand =newRandom();
87+
varrand =newSecureRandom();
8888
for (vari =0;i <5;i++) {
8989
vartime =Math.abs(rand.nextInt(1000));
9090
taskSet.addTask(newTask(time));

‎master-worker-pattern/src/main/java/com/iluwatar/masterworker/ArrayUtilityMethods.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
packagecom.iluwatar.masterworker;
2525

26-
importjava.util.Random;
26+
importjava.security.SecureRandom;
2727
importorg.slf4j.Logger;
2828
importorg.slf4j.LoggerFactory;
2929

@@ -35,7 +35,7 @@ public class ArrayUtilityMethods {
3535

3636
privatestaticfinalLoggerLOGGER =LoggerFactory.getLogger(ArrayUtilityMethods.class);
3737

38-
privatestaticfinalRandomRANDOM =newRandom();
38+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
3939

4040
/**
4141
* Method arraysSame compares 2 arrays @param a1 and @param a2 and @return whether their values

‎producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@
2323

2424
packagecom.iluwatar.producer.consumer;
2525

26-
importjava.util.Random;
26+
importjava.security.SecureRandom;
2727

2828
/**
2929
* Class responsible for producing unit of work that can be expressed as {@link Item} and submitted
3030
* to queue.
3131
*/
3232
publicclassProducer {
3333

34-
privatestaticfinalRandomRANDOM =newRandom();
34+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
3535

3636
privatefinalItemQueuequeue;
3737

‎sharding/src/main/java/com/iluwatar/sharding/LookupShardManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323

2424
packagecom.iluwatar.sharding;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.HashMap;
2728
importjava.util.Map;
28-
importjava.util.Random;
2929

3030
importorg.slf4j.Logger;
3131
importorg.slf4j.LoggerFactory;
@@ -58,7 +58,7 @@ protected int allocateShard(Data data) {
5858
returnlookupMap.get(key);
5959
}else {
6060
varshardCount =shardMap.size();
61-
returnnewRandom().nextInt(shardCount -1) +1;
61+
returnnewSecureRandom().nextInt(shardCount -1) +1;
6262
}
6363
}
6464

‎spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
packagecom.iluwatar.spatialpartition;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.HashMap;
27-
importjava.util.Random;
2828
importorg.slf4j.Logger;
2929
importorg.slf4j.LoggerFactory;
3030

@@ -112,7 +112,7 @@ static void withSpatialPartition(
112112
publicstaticvoidmain(String[]args) {
113113
varbubbles1 =newHashMap<Integer,Bubble>();
114114
varbubbles2 =newHashMap<Integer,Bubble>();
115-
varrand =newRandom();
115+
varrand =newSecureRandom();
116116
for (inti =0;i <10000;i++) {
117117
varb =newBubble(rand.nextInt(300),rand.nextInt(300),i,rand.nextInt(2) +1);
118118
bubbles1.put(i,b);

‎spatial-partition/src/main/java/com/iluwatar/spatialpartition/Bubble.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323

2424
packagecom.iluwatar.spatialpartition;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.Collection;
2728
importjava.util.HashMap;
28-
importjava.util.Random;
2929
importorg.slf4j.Logger;
3030
importorg.slf4j.LoggerFactory;
3131

@@ -36,7 +36,7 @@
3636

3737
publicclassBubbleextendsPoint<Bubble> {
3838
privatestaticfinalLoggerLOGGER =LoggerFactory.getLogger(Bubble.class);
39-
privatestaticfinalRandomRANDOM =newRandom();
39+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
4040

4141
finalintradius;
4242

‎typeobjectpattern/src/main/java/com/iluwatar/typeobject/CellPool.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
importcom.iluwatar.typeobject.Candy.Type;
2727

2828
importjava.io.IOException;
29+
importjava.security.SecureRandom;
2930
importjava.util.ArrayList;
3031
importjava.util.List;
31-
importjava.util.Random;
3232
importorg.json.simple.parser.ParseException;
3333

3434
/**
@@ -38,7 +38,7 @@
3838
*/
3939

4040
publicclassCellPool {
41-
privatestaticfinalRandomRANDOM =newRandom();
41+
privatestaticfinalSecureRandomRANDOM =newSecureRandom();
4242
publicstaticfinalStringFRUIT ="fruit";
4343
publicstaticfinalStringCANDY ="candy";
4444
List<Cell>pool;

‎update-method/src/main/java/com/iluwatar/updatemethod/World.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323

2424
packagecom.iluwatar.updatemethod;
2525

26+
importjava.security.SecureRandom;
2627
importjava.util.ArrayList;
2728
importjava.util.List;
28-
importjava.util.Random;
2929

3030
importorg.slf4j.Logger;
3131
importorg.slf4j.LoggerFactory;
@@ -66,7 +66,7 @@ private void gameLoop() {
6666
*/
6767
privatevoidprocessInput() {
6868
try {
69-
intlag =newRandom().nextInt(200) +50;
69+
intlag =newSecureRandom().nextInt(200) +50;
7070
Thread.sleep(lag);
7171
}catch (InterruptedExceptione) {
7272
LOGGER.error(e.getMessage());

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp