Commit8433c7b

authored

Merge pull requestiluwatar#793 from andrievsky/master

Fix redundant list alloc in LotteryNumbers

2 parentsee74fec +1d12d94 commit8433c7bCopy full SHA for 8433c7b

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,13 +22,12 @@`
`22`	`22`	`*/`
`23`	`23`	`packagecom.iluwatar.hexagonal.domain;`
`24`	`24`
`25`		`-importjava.util.ArrayList;`
`26`	`25`	`importjava.util.Collections;`
`27`	`26`	`importjava.util.HashSet;`
`28`		`-importjava.util.List;`
`29`	`27`	`importjava.util.PrimitiveIterator;`
`30`	`28`	`importjava.util.Random;`
`31`	`29`	`importjava.util.Set;`
	`30`	`+importjava.util.Iterator;`
`32`	`31`
`33`	`32`	`/**`
`34`	`33`	`*`
`@@ -85,11 +84,10 @@ public Set<Integer> getNumbers() {`
`85`	`84`	`* @return numbers as comma separated string`
`86`	`85`	`*/`
`87`	`86`	`publicStringgetNumbersAsString() {`
`88`		`-List<Integer>list =newArrayList<>();`
`89`		`-list.addAll(numbers);`
`90`	`87`	`StringBuilderbuilder =newStringBuilder();`
	`88`	`+Iterator<Integer>iterator =numbers.iterator();`
`91`	`89`	`for (inti =0;i <NUM_NUMBERS;i++) {`
`92`		`-builder.append(list.get(i));`
	`90`	`+builder.append(iterator.next());`
`93`	`91`	`if (i <NUM_NUMBERS -1) {`
`94`	`92`	`builder.append(",");`
`95`	`93`	`}`

Comments

(0)