Commit5d88068

committed

Review comments++

1 parentf67d2fd commit5d88068Copy full SHA for 5d88068

File tree

-8

lines changed

-8

lines changed

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,12 +45,8 @@ public final class App {`
`45`	`45`	`publicstaticvoidprepare()throwsFileNotFoundException {`
`46`	`46`
`47`	`47`	`/* Create new singleton objects and prepare their modules */`
`48`		`-fileLoggerModule =FileLoggerModule.getSingleton();`
`49`		`-consoleLoggerModule =ConsoleLoggerModule.getSingleton();`
`50`		`-`
`51`		`-/* Prepare modules */`
`52`		`-fileLoggerModule.prepare();`
`53`		`-consoleLoggerModule.prepare();`
	`48`	`+fileLoggerModule =FileLoggerModule.getSingleton().prepare();`
	`49`	`+consoleLoggerModule =ConsoleLoggerModule.getSingleton().prepare();`
`54`	`50`	`}`
`55`	`51`
`56`	`52`	`/**`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,14 @@ public static ConsoleLoggerModule getSingleton() {`
`56`	`56`	`/**`
`57`	`57`	`* Following method performs the initialization`
`58`	`58`	`*/`
`59`		`-publicvoidprepare() {`
	`59`	`+publicConsoleLoggerModuleprepare() {`
`60`	`60`
`61`	`61`	`LOGGER.debug("ConsoleLoggerModule::prepare();");`
`62`	`62`
`63`	`63`	`this.output =newPrintStream(System.out);`
`64`	`64`	`this.error =newPrintStream(System.err);`
	`65`	`+`
	`66`	`+returnthis;`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`/**`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -64,12 +64,14 @@ public static FileLoggerModule getSingleton() {`
`64`	`64`	`* @throws FileNotFoundException if program is not able to find log files (output.txt and`
`65`	`65`	`* error.txt)`
`66`	`66`	`*/`
`67`		`-publicvoidprepare()throwsFileNotFoundException {`
	`67`	`+publicFileLoggerModuleprepare()throwsFileNotFoundException {`
`68`	`68`
`69`	`69`	`LOGGER.debug("FileLoggerModule::prepare();");`
`70`	`70`
`71`	`71`	`this.output =newPrintStream(newFileOutputStream(OUTPUT_FILE));`
`72`	`72`	`this.error =newPrintStream(newFileOutputStream(ERROR_FILE));`
	`73`	`+`
	`74`	`+returnthis;`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`/**`

Comments

(0)