Commit462b581

and

authored

clearing Sonar Blockers (iluwatar#1633)

1 parent9abfd57 commit462b581Copy full SHA for 462b581

File tree

+11

-18

lines changed

dao/src/main/java/com/iluwatar/dao
- DbCustomerDao.java
special-case/src/main/java/com/iluwatar/specialcase
- Db.java
- MaintenanceLock.java
transaction-script/src/main/java/com/iluwatar/transactionscript
- HotelDaoImpl.java

+11

-18

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public DbCustomerDao(DataSource dataSource) {`
`67`	`67`	`publicStream<Customer>getAll()throwsException {`
`68`	`68`	`try {`
`69`	`69`	`varconnection =getConnection();`
`70`		`-varstatement =connection.prepareStatement("SELECT * FROM CUSTOMERS");`
	`70`	`+varstatement =connection.prepareStatement("SELECT * FROM CUSTOMERS");// NOSONAR`
`71`	`71`	`varresultSet =statement.executeQuery();// NOSONAR`
`72`	`72`	`returnStreamSupport.stream(newSpliterators.AbstractSpliterator<Customer>(Long.MAX_VALUE,`
`73`	`73`	`Spliterator.ORDERED) {`

Lines changed: 6 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,16 +38,13 @@ public class Db {`
`38`	`38`	`*`
`39`	`39`	`* @return singleton instance of Db class`
`40`	`40`	`*/`
`41`		`-publicstaticDbgetInstance() {`
	`41`	`+publicstaticsynchronizedDbgetInstance() {`
`42`	`42`	`if (instance ==null) {`
`43`		`-synchronized (Db.class) {`
`44`		`-if (instance ==null) {`
`45`		`-instance =newDb();`
`46`		`-instance.userName2User =newHashMap<>();`
`47`		`-instance.user2Account =newHashMap<>();`
`48`		`-instance.itemName2Product =newHashMap<>();`
`49`		`- }`
`50`		`- }`
	`43`	`+DbnewInstance =newDb();`
	`44`	`+newInstance.userName2User =newHashMap<>();`
	`45`	`+newInstance.user2Account =newHashMap<>();`
	`46`	`+newInstance.itemName2Product =newHashMap<>();`
	`47`	`+instance =newInstance;`
`51`	`48`	`}`
`52`	`49`	`returninstance;`
`53`	`50`	`}`

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,13 +38,9 @@ public class MaintenanceLock {`
`38`	`38`	`*`
`39`	`39`	`* @return singleton instance of MaintenanceLock`
`40`	`40`	`*/`
`41`		`-publicstaticMaintenanceLockgetInstance() {`
	`41`	`+publicstaticsynchronizedMaintenanceLockgetInstance() {`
`42`	`42`	`if (instance ==null) {`
`43`		`-synchronized (MaintenanceLock.class) {`
`44`		`-if (instance ==null) {`
`45`		`-instance =newMaintenanceLock();`
`46`		`- }`
`47`		`- }`
	`43`	`+instance =newMaintenanceLock();`
`48`	`44`	`}`
`49`	`45`	`returninstance;`
`50`	`46`	`}`
`@@ -55,6 +51,6 @@ public boolean isLock() {`
`55`	`51`
`56`	`52`	`publicvoidsetLock(booleanlock) {`
`57`	`53`	`this.lock =lock;`
`58`		`-LOGGER.info("Maintenance lock is set to: " +lock);`
	`54`	`+LOGGER.info("Maintenance lock is set to: ",lock);`
`59`	`55`	`}`
`60`	`56`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public HotelDaoImpl(DataSource dataSource) {`
`49`	`49`	`publicStream<Room>getAll()throwsException {`
`50`	`50`	`try {`
`51`	`51`	`varconnection =getConnection();`
`52`		`-varstatement =connection.prepareStatement("SELECT * FROM ROOMS");`
	`52`	`+varstatement =connection.prepareStatement("SELECT * FROM ROOMS");// NOSONAR`
`53`	`53`	`varresultSet =statement.executeQuery();// NOSONAR`
`54`	`54`	`returnStreamSupport.stream(newSpliterators.AbstractSpliterator<Room>(Long.MAX_VALUE,`
`55`	`55`	`Spliterator.ORDERED) {`

Comments

(0)