Commit3126ad3

authored

fix: Remove unnecessary and possibly not threadsafe flag (iluwatar#1811)

1 parente2ebb59 commit3126ad3Copy full SHA for 3126ad3

File tree

-8

lines changed

-8

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,16 +36,12 @@ public final class ThreadSafeDoubleCheckLocking {`
`36`	`36`
`37`	`37`	`privatestaticvolatileThreadSafeDoubleCheckLockinginstance;`
`38`	`38`
`39`		`-privatestaticbooleanflag =true;`
`40`		`-`
`41`	`39`	`/**`
`42`	`40`	`* private constructor to prevent client from instantiating.`
`43`	`41`	`*/`
`44`	`42`	`privateThreadSafeDoubleCheckLocking() {`
`45`	`43`	`// to prevent instantiating by Reflection call`
`46`		`-if (flag) {`
`47`		`-flag =false;`
`48`		`- }else {`
	`44`	`+if (instance !=null) {`
`49`	`45`	`thrownewIllegalStateException("Already initialized.");`
`50`	`46`	`}`
`51`	`47`	`}`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,7 @@ public final class ThreadSafeLazyLoadedIvoryTower {`
`34`	`34`
`35`	`35`	`privateThreadSafeLazyLoadedIvoryTower() {`
`36`	`36`	`// Protect against instantiation via reflection`
`37`		`-if (instance ==null) {`
`38`		`-instance =this;`
`39`		`- }else {`
	`37`	`+if (instance !=null) {`
`40`	`38`	`thrownewIllegalStateException("Already initialized.");`
`41`	`39`	`}`
`42`	`40`	`}`

Comments

(0)