Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add TypeScript types to release#218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Juice10 wants to merge1 commit intoBabylonJS:master
base:master
Choose a base branch
Loading
fromJuice10:patch-1

Conversation

Juice10
Copy link

Adds typescript types to the release to make it much easier for people to use Spector.js with typescript

Docs on the subject:
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

LifeIsStrange, wdanilo, bchirlsbiodigital, kirevdokimov, and nerdError reacted with thumbs up emojiLifeIsStrange, wdanilo, and kirevdokimov reacted with rocket emoji
@Juice10Juice10 changed the titleAdd typescript types to releaseAdd TypeScript types to releaseJan 4, 2022
@Juice10
Copy link
Author

Looks like we need to do one more step to get this working correctly.

Currently I'm getting the following error when importing this project into a typescript file:
File '.../node_modules/spectorjs/dist/spector.d.ts' is not a module

@RaananW
Copy link
Member

That's because the declaration file is namespace-based and not module-based. It needs to be changed (regenerated) to support modules

Juice10 reacted with thumbs up emojisebavan reacted with heart emoji

@wdanilo
Copy link

FYI, you can usetsup to generate type declarations for a bundle.

RaananW, sebavan, and nerdError reacted with heart emoji

@sebavansebavan marked this pull request as draftAugust 30, 2023 21:49
@nerdError
Copy link

Any updates?

@sebavan
Copy link
Member

last I tried tsup was not generating the bundled typings correctly :-( Would really appreciate a contrib on this subject

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Juice10@RaananW@wdanilo@nerdError@sebavan
[8]ページ先頭
©2009-2025 Movatter.jp