- Notifications
You must be signed in to change notification settings - Fork3.5k
Added OpenPBR material and option to load using glTF#16773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16773/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16773/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16773/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Uh oh!
There was an error while loading.Please reload this page.
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
I've been playing with mixins to try to remove a lot of duplicate code from the materials. I figured, if we can do this, it'll make my life easier when working on PBR2. I started with using mixins for some defines like UV1, UV2, etc. and the image-processing defines. Then, I tried actually making the imageProcessing logic into a mixin. This removes a whole bunch of duplicated stuff. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
1 similar comment
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
| import type { ColorCurves } from "./colorCurves"; | ||
| // Explicit re-export of types to help TypeScript resolve them in declaration files | ||
| export type { Observer } from "../Misc/observable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was getting errors in thenpm run build:es6 involving../.. import paths in this mixin.
An AI tool came up with the solution of adding these explicit exports. I don't really understand it but it works. It should be checked by someone who understands issues like this.
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
I've noticed another issue with my changes that I don't understand. When running a Playground in Typescript mode, I get an error about not being able to find the BABYLON namespace. Any ideas what I might have done to cause that? |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
1 similar comment
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Just so I understand correctly, for now, you have simply copied and pasted the existing PBR vertex/fragment shaders to create the OpenPBR shaders? I don't know if you have discussed the rewrite with@sebavan, but in my opinion, we should start from scratch without any defines and implement what is necessary for OpenPBR in the cleanest way possible. We can then configure the code with a few defines when necessary (but we should end up with far fewer definitions than we have now). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
| * Base Weight is a multiplier on the diffuse and metal lobes. | ||
| * See OpenPBR's specs for base_weight | ||
| */ | ||
| public baseWeight: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@sebavan Here's an example of how I'm defining properties now. Despite theeslint-disable-next-line, I still get complaints about_baseWeight not being used unless I include a reference somewhere. Right now, I'm referencing new properties in the constructor to get rid of the error.
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
No description provided.