Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Client: when computing disk usage, don't include VM shared directories#3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
davidpanderson wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromdpa_vm_disk_usage

Conversation

davidpanderson
Copy link
Contributor

These directories are inside the VM, so we've already counted them.
Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)

These directories are inside the VM, so we've already counted them.Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)
@davidpanderson
Copy link
ContributorAuthor

The Travis CI build is failing on fetching sqlite.
This can be removed; sqlite isn't used anymore.

@AenBleidd
Copy link
Member

@davidpanderson, I see sqlite3 usage still in browser.cpp
Should these functions be deleted from this class (or maybe even the whole class)?

@AenBleidd
Copy link
Member

@davidpanderson
Copy link
ContributorAuthor

davidpanderson commentedJul 14, 2020 via email

I must have forgotten to make a PR for that.
…
On Mon, Jul 13, 2020 at 5:23 PM Vitalii Koshura ***@***.***> wrote: I found this branch:https://github.com/BOINC/boinc/compare/dpa_remove_sqlite — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3901 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHQVAKQQ5K2NLJ37JC7DA3R3OQQTANCNFSM4OXGRNNA> .

@davidpanderson
Copy link
ContributorAuthor

That file (browser.cpp) should be removed.

@AenBleidd
Copy link
Member

@davidpanderson, it's already removed in a different PR

@davidpanderson
Copy link
ContributorAuthor

Actually, it turns out that shared/ resides in the host FS,
But apparently if the host (i.e. BOINC client) accesses it while the VM is running,
there's a locking mechanism or something that makes it very slow.
So let's not merge this for now.

@AenBleidd
Copy link
Member

I'm changing this PR to draft then. Feel free to change it back when you think it's ready

@AenBleiddAenBleidd marked this pull request as draftJuly 16, 2020 00:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

Assignees

@AenBleiddAenBleidd

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@davidpanderson@AenBleidd
[8]ページ先頭
©2009-2025 Movatter.jp