Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Revert: Warning Quality Check Build Task#3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexholub113
Copy link
Contributor

since these changes cause errors in the pipeline it was decided to roll them back temporarily

@alexholub113alexholub113 requested a review froma team as acode ownerJanuary 2, 2025 17:29
@keegan-caruso
Copy link
Contributor

@alexholub113 Can you link to the pipeline that is now passing with this reverted?

TimHannMSFT reacted with thumbs up emoji

@TimHannMSFT
Copy link

@alexholub113 I suspect you'll have to edit the pipeline for now to target your branch and ensure this fixes as expected I've shared more details in our internal channel. Once there's a passing pipeline run there I'll approve.

In the fullness of time we should have that pipeline take a parameter for branch and then have IDWeb PRs run that pipeline as a merge gate

@alexholub113
Copy link
ContributorAuthor

To test this revert I createdOneBranch PR.
TheOneBranch-PullRequest pipeline was successfully passed.

TimHannMSFT reacted with hooray emoji

Copy link

@TimHannMSFTTimHannMSFT left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@alexholub113 !

Please create a PBI and assign to @kellyyangsong to re-add this check once it no longer breaks the onebranch PR build

alexholub113 reacted with thumbs up emoji
@alexholub113
Copy link
ContributorAuthor

Task was created

Copy link
Contributor

@FuPingFrancoFuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@alexholub113alexholub113 merged commit8563cf9 intomasterJan 2, 2025
5 checks passed
@alexholub113alexholub113 deleted the alexholub/revert-warning-quality-check-build-task branchJanuary 2, 2025 22:48
This was referencedAug 1, 2025
This was referencedNov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@FuPingFrancoFuPingFrancoFuPingFranco approved these changes

@TimHannMSFTTimHannMSFTTimHannMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexholub113@keegan-caruso@TimHannMSFT@FuPingFranco
[8]ページ先頭
©2009-2025 Movatter.jp