Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on May 17, 2024. It is now read-only.

Update 6-2 to follow BASHER#249

Merged
derisen merged 11 commits intomainfrombasher-6-2
Dec 20, 2022
Merged

Update 6-2 to follow BASHER#249

derisen merged 11 commits intomainfrombasher-6-2
Dec 20, 2022

Conversation

@derisen
Copy link
Contributor

@derisenderisen commentedNov 30, 2022
edited
Loading

Purpose

  • Update project dependencies
  • Update README
  • Update registration scripts

Does this introduce a breaking change?

[ ] Yes[ x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix[ ] Feature[ x ] Code style update (formatting, local variables)[ x ] Refactoring (no functional changes, no api changes)[ x ] Documentation content changes[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]cd [repo-name]git checkout [branch-name]npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@derisenderisen changed the titlefirst commitUpdate 6-2 to follow BASHERNov 30, 2022
@derisenderisen marked this pull request as draftNovember 30, 2022 03:58
@v-michaelmi
Copy link
Contributor

Couple of nits.

Otherwise LGTM 👍

Copy link
Contributor

@salman90salman90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

changed the Readme titleMinor changes here and there in readme, do review once
Copy link
Contributor

@kalyankrishna1kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@derisenderisen merged commit76ccc71 intomainDec 20, 2022
@derisenderisen deleted the basher-6-2 branchDecember 20, 2022 04:34
@sa-android-adminsa-android-admin mentioned this pull requestFeb 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aremo-msaremo-msAwaiting requested review from aremo-ms

@tonyYuhaoYangMcrStonyYuhaoYangMcrSAwaiting requested review from tonyYuhaoYangMcrS

@v-michaelmiv-michaelmiAwaiting requested review from v-michaelmi

2 more reviewers

@kalyankrishna1kalyankrishna1kalyankrishna1 approved these changes

@salman90salman90salman90 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@derisen@v-michaelmi@kalyankrishna1@salman90

[8]ページ先頭

©2009-2025 Movatter.jp