Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor the flow of generate knowledge resources and add second sample for Pro mode#39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chienyuanchang wants to merge11 commits intomain
base:main
Choose a base branch
Loading
fromchienyaunchang/pro_mode_generate_resource_flow_improvement

Conversation

chienyuanchang
Copy link
Collaborator

Purpose

  • We will gather the file paths to analyze/upload first (validation first) and then do the analyze/upload once the folder is clean.

Does this introduce a breaking change?

[ ] Yes[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix[ ] Feature[ ] Code style update (formatting, local variables)[x] Refactoring (no functional changes, no api changes)[ ] Documentation content changes[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]cd [repo-name]git checkout [branch-name]npm install
  • Test the code

What to Check

Verify that the following are valid

  • Generation of notebook works normal

Other Information

@chienyuanchangchienyuanchang changed the titleRefactor the flow of generate knowledge resources for Pro modeRefactor the flow of generate knowledge resources and add second sample for Pro modeJul 18, 2025
Copy link
Collaborator

@yungshinlintwyungshinlintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For set_env_for_training_data_and_reference_doc.md, let's improve it by clarifying step 6: Set Environment Variables in.env File.

Let's call out:

  • Depending on the sample that you will run, you will need to set required environment variables in .env.

6.1:anlayzer_training Add the SAS URL as value ofTRAINIGN_DATA_SAS_URL, and a prefix forTRAINING_DATA_PATH. You can pick your own value, for example 'training_files'.

TRAINING_DATA_SAS_URL=<Blob container SAS URL>TRAINING_DATA_PATH=<Designated folder path under the blob container>

6.2 ....

chienyuanchang reacted with thumbs up emoji
@chienyuanchang
Copy link
CollaboratorAuthor

For set_env_for_training_data_and_reference_doc.md, let's improve it by clarifying step 6: Set Environment Variables in.env File.

Let's call out:

  • Depending on the sample that you will run, you will need to set required environment variables in .env.

6.1:anlayzer_training Add the SAS URL as value ofTRAINIGN_DATA_SAS_URL, and a prefix forTRAINING_DATA_PATH. You can pick your own value, for example 'training_files'.

TRAINING_DATA_SAS_URL=<Blob container SAS URL>TRAINING_DATA_PATH=<Designated folder path under the blob container>

6.2 ....

@yungshinlintw, I've improved set_env_for_training_data_and_reference_doc.md by the suggestion in this comment. But, I couldn't reply/close this comment directly.

Copy link
Collaborator

@yungshinlintwyungshinlintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approve with more suggestions to improve the explanation text. Thanks a lot for the work here!

"cell_type":"markdown",
"metadata": {},
"source": [
"### Generate knowledge base for the second sample\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Remove "\n". This seems to cause the markdown not to display correctly in the Codespace.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"\n" is added by notebook automatically. Mine codebase is good.
image

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Won't fix

"cell_type":"markdown",
"metadata": {},
"source": [
"> In the LineItemCorroboration field, we see that each line item is extracted with its corresponding information, claim status, and evidence. Items that are not covered by the policy, such as the Starbucks drink and hotel stay, are not confirmed, while damage repairs that are supported by the supplied documents in the claim and are permitted by the policy are confirmed."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"are marked as suspicious."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also mention that these are generated from repair estimate document.

On top of these, can you please add another cell to show information that is only being avaiable from the car accident report.

This can better show that the information are extracted from both documents to generate one result. It will be great to explain the N:1 (input to analysis result) relationship. We also want to explain that there is always one anlaysis result, and this is not a batch model (N input documents to generate N analysis result).

We want to strive to provide our samples as a good source of learning the functionalties, so I would like to explain more knowlege beyond showing the code to call our serivce. Thanks!

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Current field schema does not have the field only available from the car accident report. I'm adding a new field "ReportingOfficer".

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added additional field and explanation

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@yungshinlintwyungshinlintwyungshinlintw approved these changes

@juliagongmsjuliagongmsAwaiting requested review from juliagongms

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@chienyuanchang@yungshinlintw

[8]ページ先頭

©2009-2025 Movatter.jp