- Notifications
You must be signed in to change notification settings - Fork27
Refactor the flow of generate knowledge resources and add second sample for Pro mode#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For set_env_for_training_data_and_reference_doc.md, let's improve it by clarifying step 6: Set Environment Variables in.env
File.
Let's call out:
- Depending on the sample that you will run, you will need to set required environment variables in .env.
6.1:anlayzer_training Add the SAS URL as value ofTRAINIGN_DATA_SAS_URL, and a prefix forTRAINING_DATA_PATH. You can pick your own value, for example 'training_files'.
TRAINING_DATA_SAS_URL=<Blob container SAS URL>TRAINING_DATA_PATH=<Designated folder path under the blob container>
6.2 ....
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@yungshinlintw, I've improved set_env_for_training_data_and_reference_doc.md by the suggestion in this comment. But, I couldn't reply/close this comment directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approve with more suggestions to improve the explanation text. Thanks a lot for the work here!
Uh oh!
There was an error while loading.Please reload this page.
"cell_type":"markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"### Generate knowledge base for the second sample\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Remove "\n". This seems to cause the markdown not to display correctly in the Codespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Won't fix
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
"cell_type":"markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"> In the LineItemCorroboration field, we see that each line item is extracted with its corresponding information, claim status, and evidence. Items that are not covered by the policy, such as the Starbucks drink and hotel stay, are not confirmed, while damage repairs that are supported by the supplied documents in the claim and are permitted by the policy are confirmed." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"are marked as suspicious."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also mention that these are generated from repair estimate document.
On top of these, can you please add another cell to show information that is only being avaiable from the car accident report.
This can better show that the information are extracted from both documents to generate one result. It will be great to explain the N:1 (input to analysis result) relationship. We also want to explain that there is always one anlaysis result, and this is not a batch model (N input documents to generate N analysis result).
We want to strive to provide our samples as a good source of learning the functionalties, so I would like to explain more knowlege beyond showing the code to call our serivce. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Current field schema does not have the field only available from the car accident report. I'm adding a new field "ReportingOfficer".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added additional field and explanation
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information