Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

Add events#354

Open
ap-git-hub wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromtelemetry
Open

Add events#354

ap-git-hub wants to merge1 commit intomasterfromtelemetry

Conversation

@ap-git-hub
Copy link
Contributor

@ap-git-hubap-git-hub commentedApr 17, 2019
edited by dluc
Loading

Description and Motivation

Added events for start, stop, restart simulation.

Change type

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

This change is Reviewable

{
simulation=awaitthis.ResetSimulationStatisticsAsync(simulation);

simulation=awaitthis.ResetSimulationStatisticsAsync(simulation);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

duplicate statement!!

Suggested change
simulation = await this.ResetSimulationStatisticsAsync(simulation);

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@peterfeltspeterfeltsAwaiting requested review from peterfelts

@saixiaohuisaixiaohuiAwaiting requested review from saixiaohui

@pratik11jainpratik11jainAwaiting requested review from pratik11jain

@tommo-mstommo-msAwaiting requested review from tommo-ms

1 more reviewer

@sarthakvijayvergiyasarthakvijayvergiyasarthakvijayvergiya requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ap-git-hub@sarthakvijayvergiya@avani-kp

[8]ページ先頭

©2009-2025 Movatter.jp