- Notifications
You must be signed in to change notification settings - Fork3.2k
Wangamber/llmspeechtest#44165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Wangamber/llmspeechtest#44165
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…/amber-yujueWang/azure-sdk-for-python into wangamber/llmspeechsdkpreviewfix
…jueWang/azure-sdk-for-python into wangamber/llmspeechtest
…jueWang/azure-sdk-for-python into wangamber/llmspeechtest
…jueWang/azure-sdk-for-python into wangamber/llmspeechtest
7c59675 tobf250c3CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This pull request adds comprehensive test coverage for the azure-ai-transcription SDK, replacing auto-generated test templates with well-structured manual tests. The PR includes tests for synchronous and asynchronous clients covering URL-based transcription, file-based transcription, transcription options (profanity filtering, phrase lists, multiple locales), speaker diarization, enhanced mode, and client lifecycle management.
Key changes:
- Added 14 new test files covering various transcription scenarios (basic, URL, file, options, diarization, enhanced mode, client management)
- Implemented custom test preparer and conftest for test infrastructure with proper credential handling and sanitization
- Added test assets (audio WAV files) and configuration files (.env.template, assets.json, .gitignore)
- Removed 4 auto-generated test files from the generated_tests directory
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/preparer.py | Test base class and environment loader with flexible credential handling |
| tests/conftest.py | Pytest configuration with comprehensive sanitization for recordings |
| tests/test_transcription_*.py | 14 test files covering various transcription features and scenarios |
| tests/.env.template | Environment variable template for test configuration |
| tests/assets/*.wav | Test audio files for transcription tests |
| assets.json | Test asset configuration for Azure SDK test recordings |
| .gitignore | Git ignore patterns for Python artifacts and test data |
| generated_tests/* | Removed auto-generated test templates (4 files) |
| import pytest | ||
| from devtools_testutils import recorded_by_proxy | ||
| from preparer import TranscriptionClientTestBase, TranscriptionPreparer | ||
| from azure.ai.transcription.models import TranscriptionOptions |
CopilotAINov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TheTranscriptionOptions import is unused in this file. It should be removed to avoid unused imports.
| from azure.ai.transcription.models import TranscriptionOptions |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines