Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Open Telemetry: Fixes attribute name following otel convention#4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007sourabh1007 commentedOct 8, 2024•
edited
Loading

Description

What is the change?

db.cosmosdb.operation_type--> removed (moved to classic sdk support)
db.cosmosdb.machine_id --> removed (moved to classic sdk support)
db.cosmosdb.client_id -->db.cosmosdb.client.id it will remain same(aligns with OTel messaging conventions)
db.cosmosdb.request_content_length -->db.cosmosdb.request.content_length it will remain same(aligns with OTel HTTP conventions)
db.cosmosdb.response_content_length -->db.cosmosdb.request.content_length it will remain same(aligns with OTel HTTP conventions)
db.cosmosdb.status_code -->db.response.status_code (moveddb.cosmosdb.status_code to classic sdk support)
db.cosmosdb.consistency_level -> added
db.cosmosdb.request_content_length_bytes -> added for classic sdk support

Why?

Lot of discussions are going on with Azure Core and Open Telemetry Community teams. As part of that discussion, we are making these changes as our goal is to be Open Telemetry and Azure compliant,

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue:closes#4553

lmolkova reacted with thumbs up emoji
Copy link

@github-actionsgithub-actionsbot left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All good!

@sourabh1007sourabh1007 changed the titleOpen Telemetry : fixes attribute name follwing otel conventionOpen Telemetry : Fixes attribute name following otel conventionOct 8, 2024
@sourabh1007sourabh1007 changed the titleOpen Telemetry : Fixes attribute name following otel conventionOpen Telemetry: Fixes attribute name following otel conventionOct 8, 2024
@sourabh1007sourabh1007 marked this pull request as ready for reviewOctober 8, 2024 08:26
Copy link
Contributor

@philipthomas-MSFTphilipthomas-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: Just some encouragement to provide more explicit context on why these changes are important.

@sourabh1007sourabh1007 self-assigned thisOct 8, 2024
@sourabh1007sourabh1007force-pushed theusers/sourabhjain/tracesnamechanges branch froma6f3081 to4aedd08CompareOctober 8, 2024 18:28
@sourabh1007sourabh1007force-pushed theusers/sourabhjain/tracesnamechanges branch 2 times, most recently from4f23195 to1b42f26CompareOctober 9, 2024 11:50
kirankumarkolli
kirankumarkolli previously approved these changesOct 9, 2024
@lmolkova
Copy link

The proposal looks good to me!

There is a caveat that we can't update OTel semantic conventions with this:

db.cosmosdb.client_id --> db.cosmosdb.client.id (aligns with OTel messaging conventions)db.cosmosdb.request_content_length --> db.request.content_length (aligns with OTel HTTP conventions)db.cosmosdb.response_content_length --> db.response.content_length (aligns with OTel HTTP conventions)

because of some tooling/process issues. I'm working on addressing them, but in the meantime we'll need to either hold back this part of the change or be inconsistent with what's documented in the OTel today until tooling problems are resolved.

@kirankumarkolli
Copy link
Member

The proposal looks good to me!

There is a caveat that we can't update OTel semantic conventions with this:

db.cosmosdb.client_id --> db.cosmosdb.client.id (aligns with OTel messaging conventions)db.cosmosdb.request_content_length --> db.request.content_length (aligns with OTel HTTP conventions)db.cosmosdb.response_content_length --> db.response.content_length (aligns with OTel HTTP conventions)

because of some tooling/process issues. I'm working on addressing them, but in the meantime we'll need to either hold back this part of the change or be inconsistent with what's documented in the OTel today until tooling problems are resolved.

What's the timeline for tooling readiness?

@sourabh1007sourabh1007force-pushed theusers/sourabhjain/tracesnamechanges branch from8cff9df tod9a96a2CompareOctober 10, 2024 03:12
@sourabh1007sourabh1007force-pushed theusers/sourabhjain/tracesnamechanges branch fromedeb94f toe49571cCompareOctober 10, 2024 06:06
@sourabh1007sourabh1007 added the auto-mergeEnables automation to merge PRs labelOct 11, 2024
@sourabh1007
Copy link
ContributorAuthor

The proposal looks good to me!
There is a caveat that we can't update OTel semantic conventions with this:

db.cosmosdb.client_id --> db.cosmosdb.client.id (aligns with OTel messaging conventions)db.cosmosdb.request_content_length --> db.request.content_length (aligns with OTel HTTP conventions)db.cosmosdb.response_content_length --> db.response.content_length (aligns with OTel HTTP conventions)

because of some tooling/process issues. I'm working on addressing them, but in the meantime we'll need to either hold back this part of the change or be inconsistent with what's documented in the OTel today until tooling problems are resolved.

What's the timeline for tooling readiness?

We discussed this with@lmolkova and estimated that tool readiness would take about one month. However, we agreed it's not a high-priority task, as we're comfortable with the current naming, provided the OpenTelemetry community accepts it. We would, however, be hesitant to make changes in the future.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot merged commit72eed8a intomasterOct 15, 2024
23 checks passed
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot deleted the users/sourabhjain/tracesnamechanges branchOctober 15, 2024 02:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jcocchijcocchijcocchi approved these changes

@kirankumarkollikirankumarkollikirankumarkolli approved these changes

@khdangkhdangAwaiting requested review from khdangkhdang is a code owner

@sboshrasboshraAwaiting requested review from sboshrasboshra is a code owner

@adityasaadityasaAwaiting requested review from adityasaadityasa is a code owner

@neildshneildshAwaiting requested review from neildshneildsh is a code owner

@FabianMeiswinkelFabianMeiswinkelAwaiting requested review from FabianMeiswinkelFabianMeiswinkel is a code owner

@kirillgkirillgAwaiting requested review from kirillgkirillg is a code owner

@PilchiePilchieAwaiting requested review from PilchiePilchie is a code owner

+2 more reviewers

@lmolkovalmolkovalmolkova left review comments

@philipthomas-MSFTphilipthomas-MSFTphilipthomas-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sourabh1007sourabh1007

Labels

auto-mergeEnables automation to merge PRsTelemetry

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Distributed Tracing/Open Telemetry: Feature requests

6 participants

@sourabh1007@lmolkova@kirankumarkolli@jcocchi@philipthomas-MSFT
[8]ページ先頭
©2009-2025 Movatter.jp